-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: course about page markup and styles improvements #33712
feat: course about page markup and styles improvements #33712
Conversation
Thanks for the pull request, @bydawen! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi! I'm contributing on behalf of Raccoongang |
edcf611
to
01a3a0a
Compare
@mphilbrick211 I can take this as a CC review once the product review is done. :) |
Thank you, @farhaanbukhsh! |
@bydawen Thank you for this contribution! I'll be performing the product review. A few notes/questions:
Thank you. |
Hey @bydawen any updates here? |
77e7538
to
53e9ea0
Compare
Hello @ali-hugo
|
Hi @ihor-romaniuk, I think having the organisation name in the sidebar works well on desktop, but I wonder if it is too far down on the page on mobile. Perhaps the sidebar information should be moved above the "about this course" section on mobile. @jmakowski1123 Would you be happy with that from a UX perspective? |
Tagging @marcotuts to make the call about mobile UI. |
Hi @marcotuts! Friendly follow-up on this. |
My suggestion here is to put more space betweeen the org and the description, 20px perhaps minimum. Another suggestion is to put the org above the title, which echoed the design of many other course cards with org (in small text) then course title (larger text) then fellow that description or subtitle like content . Hopefully this helps! |
@marcotuts, per your recommendations, I moved the organization name above the course title to match the style of the course cards. |
Backport to Redwood: #34892 |
update: Product review is done here, this can move to the next step thanks! |
@farhaanbukhsh Hey, the product review has been passed! Will you be able to do a tech review? |
@ihor-romaniuk please rebase your branch |
d7d44ba
to
6ca7e4e
Compare
The branch is up-to-date. |
@idegtiarov @ihor-romaniuk will you also be able to take of the backports? |
6ca7e4e
to
d440068
Compare
@mphilbrick211 All PRs were updated and ready for review or merge. Thanks. |
Thanks @ihor-romaniuk I will have a look at it early next week :) |
d440068
to
23a25a3
Compare
23a25a3
to
5ef014a
Compare
@farhaanbukhsh I believe everything is ready for the final review and merging of this pull request. Could we proceed with that? |
@ihor-romaniuk sure I will try to get this merged today or tomorrow :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- ✅ I tested this on tutor master devstack and it is working
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Similar PR is opened to the open-release/palm branch:
#33711
There is some fixes for the course about page:
% if get_course_about_section(request, course, "prerequisites"):
Fixes were also made to the
_course_about.scss
styles, to fix responsive layout of the course about header element.Before fixes:
After fixes: