Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fields for holding encrypted data in database for blackboard #1907

Merged

Conversation

MueezKhan246
Copy link
Contributor

Description:
Added encryption fields to the model of blackboard config.

JIRA:
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-5613

MueezKhan246 and others added 18 commits October 11, 2023 14:27
…to MueezKhan/Encryption-Fields-Added-To-BlackboardConfig
…to MueezKhan/Encryption-Fields-Added-To-BlackboardConfig
…to MueezKhan/Encryption-Fields-Added-To-BlackboardConfig
…Khan/Encryption-Fields-Added-To-BlackboardConfig
…Khan/Encryption-Fields-Added-To-BlackboardConfig
…Khan/Encryption-Fields-Added-To-BlackboardConfig
…of github.com:openedx/edx-enterprise into MueezKhan/Encryption-Fields-Added-To-BlackboardConfig
Copy link
Contributor

@sameeramin sameeramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Comment on lines 19 to 20
'client_id',
'client_secret',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove these two fields from here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sameenfatima78 i planned to create a separate PR for removing these and feature flag, like done for other integrated channels

@MueezKhan246 MueezKhan246 merged commit c8c6c53 into master May 7, 2024
13 checks passed
@MueezKhan246 MueezKhan246 deleted the MueezKhan/Encryption-Fields-Added-To-BlackboardConfig branch May 7, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants