-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fields for holding encrypted data in database for blackboard #1907
Added fields for holding encrypted data in database for blackboard #1907
Conversation
…to MueezKhan/Encryption-Fields-Added-To-BlackboardConfig
…to MueezKhan/Encryption-Fields-Added-To-BlackboardConfig
…to MueezKhan/Encryption-Fields-Added-To-BlackboardConfig
…Khan/Encryption-Fields-Added-To-BlackboardConfig
…Khan/Encryption-Fields-Added-To-BlackboardConfig
…Khan/Encryption-Fields-Added-To-BlackboardConfig
…of github.com:openedx/edx-enterprise into MueezKhan/Encryption-Fields-Added-To-BlackboardConfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
'client_id', | ||
'client_secret', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove these two fields from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sameenfatima78 i planned to create a separate PR for removing these and feature flag, like done for other integrated channels
…Khan/Encryption-Fields-Added-To-BlackboardConfig
Description:
Added encryption fields to the model of blackboard config.
JIRA:
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-5613