-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added dry-run mode for content_metadata transmission #1883
Conversation
f968cfc
to
fd971d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depending on how you intent to consume/parse these dry-run logs you may want to make the logging more granular
integrated_channels/integrated_channel/transmitters/content_metadata.py
Outdated
Show resolved
Hide resolved
integrated_channels/integrated_channel/transmitters/content_metadata.py
Outdated
Show resolved
Hide resolved
Thank you @johnnagro for your valuable feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A side effect of this implementation is that content transmission audits will retain the marked_for
field value set by the exporter (as it's the job of the transmitter to remove the value). Theoretically this is fine as the value simply denotes the exporter identifying the content needs updating in some way, but we should double check that we want the dry run to effect records in the database (perhaps it's even a benefit?).
integrated_channels/integrated_channel/transmitters/content_metadata.py
Outdated
Show resolved
Hide resolved
fd971d1
to
fcd79ef
Compare
fcd79ef
to
1b85168
Compare
@johnnagro @alex-sheehan-edx I've added course_run_key variable in the generate_log_line method. |
7afe445
to
7517180
Compare
Ticket: https://2u-internal.atlassian.net/browse/ENT-5959
Adds support for dry run mode to work with transmission of content metadata.
Dry Run mode could be enabled using this flag.
Merge checklist:
requirements/*.txt
files)base.in
if needed in production but edx-platform doesn't install ittest-master.in
if edx-platform pins it, with a matching versionmake upgrade && make requirements
have been run to regenerate requirementsmake static
has been run to update webpack bundling if any static content was updated./manage.py makemigrations
has been run./manage.py lms makemigrations
in the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in edx-platform will look for the latest version in PyPi.