feanil/xblock tests #249
Merged
feanil/xblock tests #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
feanil
commented
Aug 23, 2022
feanil
commented
- test: Actually run the xblock tests against the xblock cookiecutter.
- test: Fix tests and xblock cookiecutter to get things passing.
It looks like the path was never updated so we haven't been running tests against the xblock cookiecutter.
|
@ziafazal FYI, this is why we didn't catch the issue you saw earlier. |
feanil
force-pushed
the
feanil/xblock-tests
branch
from
fdaa1c4 to
eb34517
Compare
ormsbee
approved these changes
Aug 23, 2022
|
Created #250 to deal with the pydocstyles issue. |
feanil
force-pushed
the
feanil/xblock-tests
branch
from
eb34517 to
1f90f4c
Compare
As a part of this change, we currently stopped checking the docstyles on files in the generated xblock as a part of our test. This is beacuse that particular repo has a significant number of docstyle failures and we didn't want to block on that to get the rest of the tests running on the correct cookiecutter. An issue will be created to track fixing the failing docstyle check so that we can enable that in the future.
feanil
force-pushed
the
feanil/xblock-tests
branch
from
1f90f4c to
8ce2a0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.