Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove xblock-utils package #25

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

farhan
Copy link
Contributor

@farhan farhan commented Oct 10, 2023

ticket: #23
child PR: #29

ScreenShot of running xblock after the changes:
image

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c5ff627) 91.53% compared to head (92f93fc) 91.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files           1        1           
  Lines         130      130           
=======================================
  Hits          119      119           
  Misses         11       11           
Flag Coverage Δ
unittests 91.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
feedback/feedback.py 91.53% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@farhan farhan force-pushed the farhan/remove-xblockutils branch from 750bf1b to 31f34f0 Compare October 10, 2023 10:12
@farhan farhan linked an issue Oct 10, 2023 that may be closed by this pull request
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but needs a rebase to deal with conflicts.

@farhan farhan force-pushed the farhan/remove-xblockutils branch from 97a2258 to ceb9614 Compare October 19, 2023 04:46
@farhan farhan merged commit 8e75dfd into master Oct 19, 2023
5 checks passed
@farhan farhan deleted the farhan/remove-xblockutils branch October 19, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove xblockutils package
2 participants