Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: added workflow to comment next version on PR raise trigger #143

Conversation

huniafatima-arbi
Copy link
Contributor

@huniafatima-arbi huniafatima-arbi commented Jul 11, 2024

Description

Semantic release was being used to comment the release version upon merging the PR. We needed to know the expected version of the release prior to merging. This PR adds the workflow to comment the expected release version.

Ticket Link

openedx/wg-frontend#139

Test

Tested the workflow on following PR
edx/frontend-component-header-edx#586

.github/workflows/expected-release-version.yml Outdated Show resolved Hide resolved
.github/workflows/expected-release-version.yml Outdated Show resolved Hide resolved
.github/workflows/expected-release-version.yml Outdated Show resolved Hide resolved
.github/workflows/expected-release-version.yml Outdated Show resolved Hide resolved
.github/workflows/expected-release-version.yml Outdated Show resolved Hide resolved
.github/workflows/expected-release-version.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use semantic release with a different config instead of adding new logic ourselves.

See the examples in the replies in this issue: semantic-release/semantic-release#1647

@huniafatima-arbi
Copy link
Contributor Author

huniafatima-arbi commented Aug 2, 2024

Why not just use semantic release with a different config instead of adding new logic ourselves.

See the examples in the replies in this issue: semantic-release/semantic-release#1647

@feanil I tried above mentioned suggestions and solutions. It came out to be the same outcome as before. semantic-release bails out before finalizing the version if the action trigger is pull request. I have attached the screenshot as well for reference.
Screenshot 2024-08-02 at 12 27 29 PM

Please let me know if we can go further with the solution provided by this PR or we should explore other github actions for expected version of release.
Thank you

@feanil
Copy link
Contributor

feanil commented Aug 6, 2024

@huniafatima-arbi I think you'll want to run with --no-ci so that it skips the environment verifications and just spits out the version number.

@huniafatima-arbi huniafatima-arbi deleted the huniafatima/release-expected-version-workflow branch September 13, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants