Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Commit

Permalink
Update snowflake and ga includes for isort.
Browse files Browse the repository at this point in the history
Also update Makefile so that venv gets properly populated before calling
isort within that venv.
  • Loading branch information
brianhw committed Apr 18, 2019
1 parent ad0d76e commit b7dae0c
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
7 changes: 5 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,15 @@ test-acceptance-local:
test-acceptance-local-all:
REMOTE_TASK=$(shell which remote-task) LUIGI_CONFIG_PATH='config/test.cfg' ACCEPTANCE_TEST_CONFIG="/var/tmp/acceptance.json" python -m coverage run --rcfile=./.coveragerc -m nose --nocapture --with-xunit -A acceptance -v

quality-docker-local:
quality-local:
bash -c 'source ${ANALYTICS_PIPELINE_VENV}/analytics_pipeline/bin/activate && isort --check-only --recursive edx/'
pycodestyle edx

quality-docker-local:
docker run --rm -u root -v `(pwd)`:/edx/app/analytics_pipeline/analytics_pipeline -it edxops/analytics_pipeline:latest make develop-local quality-local

quality-docker:
docker run --rm -u root -v `(pwd)`:/edx/app/analytics_pipeline/analytics_pipeline -it edxops/analytics_pipeline:latest make quality-docker-local
docker run --rm -u root -v `(pwd)`:/edx/app/analytics_pipeline/analytics_pipeline -it edxops/analytics_pipeline:latest make reset-virtualenv test-requirements develop-local quality-local

coverage-docker:
docker run --rm -u root -v `(pwd)`:/edx/app/analytics_pipeline/analytics_pipeline -it edxops/analytics_pipeline:latest coverage xml
Expand Down
4 changes: 2 additions & 2 deletions edx/analytics/tasks/common/snowflake_load.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
import logging

import luigi
import snowflake.connector
from cryptography.hazmat.backends import default_backend
from cryptography.hazmat.primitives import serialization
from snowflake.connector import ProgrammingError

import snowflake.connector
from edx.analytics.tasks.util.overwrite import OverwriteOutputMixin
from edx.analytics.tasks.util.url import ExternalURL
from snowflake.connector import ProgrammingError

log = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion edx/analytics/tasks/warehouse/load_ga_permissions.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
import logging

import luigi
from apiclient.discovery import build
from google.oauth2 import service_account

from apiclient.discovery import build
from edx.analytics.tasks.common.vertica_load import VerticaCopyTask, VerticaCopyTaskMixin
from edx.analytics.tasks.util.hive import WarehouseMixin
from edx.analytics.tasks.util.overwrite import OverwriteOutputMixin
Expand Down

0 comments on commit b7dae0c

Please sign in to comment.