Additional PHP path sanitization #1296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilpig
reviewed
Nov 5, 2021
| # Make sure we don't have any path shenanigans going on | ||
| $path=str_replace(array("..","./"),"",$path); | ||
| # we don't need trailing slashes, and leading slashes are going to be invalid paths | ||
| $path=trim($path,"/"); | ||
| $path=sanitize(trim($path,"/")); |
There was a problem hiding this comment.
Why would you sanitize this again after it was done four lines up?
wilpig
reviewed
Nov 5, 2021
| @@ -120,7 +120,7 @@ function BuildFileList($returnjson=false,$path="."){ | |||
| # Make sure we don't have any path shenanigans going on | |||
| $path=str_replace(array("..","./"),"",$path); | |||
| # we don't need trailing slashes, and leading slashes are going to be invalid paths | |||
| $path=trim($path,"/"); | |||
| $path=sanitize(trim($path,"/")); | |||
Code injection test cases |
|
The path is getting manipulated again after it’s sanitized. I wonder if it actually makes more sense to have the sanitization be the last thing that happens to the path instead of the first? |
|
The santitize function is to protect against user injected crap. It's not being touched by the user after the first sanitize() call, therefore any subsequent calls to it are simply wasted cycles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eb143e5 added PHP sanitization to one
$path=trim($path), but there were three others, so this PR adds the same logic to those