Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile.ubi: use vllm tgis adapter #39

Merged

Conversation

dtrifiro
Copy link

@dtrifiro dtrifiro commented May 28, 2024

Copy link

openshift-ci bot commented May 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dtrifiro dtrifiro requested a review from z103cb May 28, 2024 16:42
@opendatahub-io opendatahub-io deleted a comment from openshift-ci bot May 28, 2024
@dtrifiro
Copy link
Author

/test all

Copy link

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro, z103cb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dtrifiro

This comment was marked as outdated.

@dtrifiro dtrifiro force-pushed the use-vllm-tgis-adapter branch from 358c7da to 54ecf0d Compare May 31, 2024 09:28
@openshift-ci openshift-ci bot removed the lgtm label May 31, 2024
Copy link

openshift-ci bot commented May 31, 2024

New changes are detected. LGTM label has been removed.

@dtrifiro dtrifiro changed the title use vllm tgis adapter Dockerfile.ubi: use vllm tgis adapter May 31, 2024
@dtrifiro dtrifiro force-pushed the use-vllm-tgis-adapter branch from 54ecf0d to 6271c04 Compare May 31, 2024 11:42
@dtrifiro dtrifiro marked this pull request as ready for review May 31, 2024 12:10
@openshift-ci openshift-ci bot requested review from heyselbi and rpancham May 31, 2024 12:10
@openshift-merge-bot openshift-merge-bot bot merged commit cab241c into opendatahub-io:main May 31, 2024
16 checks passed
@dtrifiro dtrifiro deleted the use-vllm-tgis-adapter branch May 31, 2024 18:22
Xaenalt pushed a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants