Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile cleanup #14

Merged

Conversation

dtrifiro
Copy link

@dtrifiro dtrifiro commented May 7, 2024

@dtrifiro dtrifiro force-pushed the dockerfile-cleanup-rebased branch from f0eee30 to fd0261d Compare May 7, 2024 16:27
@dtrifiro dtrifiro marked this pull request as draft May 7, 2024 16:27
@dtrifiro dtrifiro force-pushed the dockerfile-cleanup-rebased branch 2 times, most recently from a167921 to 07530c8 Compare May 8, 2024 09:59
- get rid of --link flags for COPY operations:
  not supported by openshift CI (buildah)
  See containers/buildah#4325
- get rid of conda
- install ccache to leverage caching
@openshift-ci openshift-ci bot added the approved label May 8, 2024
@dtrifiro dtrifiro mentioned this pull request May 8, 2024
@dtrifiro dtrifiro marked this pull request as ready for review May 8, 2024 10:00
@openshift-ci openshift-ci bot requested review from rpancham and z103cb May 8, 2024 10:00
@dtrifiro dtrifiro mentioned this pull request May 8, 2024
Copy link

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test
/approved

@openshift-ci openshift-ci bot removed the lgtm label May 8, 2024
Copy link

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 8, 2024
Copy link

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro, z103cb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dtrifiro dtrifiro enabled auto-merge (rebase) May 8, 2024 10:58
@dtrifiro dtrifiro merged commit ca06561 into opendatahub-io:ibm_main May 8, 2024
2 of 3 checks passed
@dtrifiro dtrifiro mentioned this pull request May 15, 2024
dtrifiro pushed a commit that referenced this pull request Jul 26, 2024
prarit pushed a commit to prarit/vllm that referenced this pull request Oct 18, 2024
enable fused topK_softmax kernel for hip path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants