Skip to content

Commit

Permalink
77_spec - Rename Relationship to DataRelationship data entity for nam…
Browse files Browse the repository at this point in the history
…ing consistency (#1661)
  • Loading branch information
Vladysl authored Apr 18, 2024
1 parent a292d5f commit b4c0e4b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ spring-starter-cloud = '3.1.0'
spring-starter-bootstrap = '3.1.0'
reactor-extra = '3.5.1'
micrometer-registry-prometheus = '1.9.0'
ingestion-contract-server = '0.1.39'
ingestion-contract-server = '0.1.40'
oddrn-generator-java = '0.1.21'
odd-integration-manifests = '0.0.6'
apache-collections = '4.4'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@
import org.opendatadiscovery.oddplatform.ingestion.contract.model.DataInput;
import org.opendatadiscovery.oddplatform.ingestion.contract.model.DataQualityTest;
import org.opendatadiscovery.oddplatform.ingestion.contract.model.DataQualityTestRun;
import org.opendatadiscovery.oddplatform.ingestion.contract.model.DataRelationship;
import org.opendatadiscovery.oddplatform.ingestion.contract.model.DataSet;
import org.opendatadiscovery.oddplatform.ingestion.contract.model.DataSetField;
import org.opendatadiscovery.oddplatform.ingestion.contract.model.DataSetFieldType;
import org.opendatadiscovery.oddplatform.ingestion.contract.model.DataTransformer;
import org.opendatadiscovery.oddplatform.ingestion.contract.model.DataTransformerRun;
import org.opendatadiscovery.oddplatform.ingestion.contract.model.ERDRelationship;
import org.opendatadiscovery.oddplatform.ingestion.contract.model.GraphRelationship;
import org.opendatadiscovery.oddplatform.ingestion.contract.model.Relationship;
import org.opendatadiscovery.oddplatform.ingestion.contract.model.Tag;
import org.opendatadiscovery.oddplatform.model.tables.pojos.DataEntityPojo;
import org.opendatadiscovery.oddplatform.service.ingestion.DatasetVersionHashCalculator;
Expand Down Expand Up @@ -99,7 +99,7 @@ public class IngestionMapperImpl implements IngestionMapper {
Pair.of(de -> de.getDataQualityTestRun() != null, DATA_QUALITY_TEST_RUN),
Pair.of(de -> de.getDataEntityGroup() != null, DATA_ENTITY_GROUP),
Pair.of(de -> de.getDataInput() != null, DATA_INPUT),
Pair.of(de -> de.getDataEntityRelationship() != null, DATA_RELATIONSHIP)
Pair.of(de -> de.getDataRelationship() != null, DATA_RELATIONSHIP)
);

@Override
Expand Down Expand Up @@ -152,7 +152,7 @@ public DataEntityIngestionDto createIngestionDto(final DataEntity dataEntity, fi
}

if (entityClasses.contains(DATA_RELATIONSHIP)) {
builder = builder.dataRelationshipDto(createDataRelationship(dataEntity.getDataEntityRelationship()));
builder = builder.dataRelationshipDto(createDataRelationship(dataEntity.getDataRelationship()));
}

return builder.build();
Expand Down Expand Up @@ -310,9 +310,9 @@ private DataInputIngestionDto createDataInput(final DataInput dataInput) {
);
}

private DataRelationshipDto createDataRelationship(final Relationship relationship) {
private DataRelationshipDto createDataRelationship(final DataRelationship relationship) {
final DataRelationshipDetailsDto dataRelationshipDetailsDto =
Relationship.RelationshipTypeEnum.ERD == relationship.getRelationshipType()
DataRelationship.RelationshipTypeEnum.ERD == relationship.getRelationshipType()
? new DataRelationshipDetailsDto(
erdRelationIngestionMapper.mapERDRelation((ERDRelationship) relationship.getDetails()),
null)
Expand Down

0 comments on commit b4c0e4b

Please sign in to comment.