-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove urlpath dependency and update relative path logic #602
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #602 +/- ##
===========================================
- Coverage 76.71% 76.68% -0.04%
===========================================
Files 41 41
Lines 2998 2959 -39
===========================================
- Hits 2300 2269 -31
+ Misses 698 690 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with minor comment.
(Oh, and bump the version number while you're at it, and I'll do a release once merged.)
return asset_href | ||
|
||
self_path = urlparse(self_link).path | ||
href_path = urlparse(asset_href).path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems unlikely, but for completeness, I think we should be explicitly checking that both self_link
and asset_href
have the same scheme
and netloc
(and keeping as an absolute link if they differ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could refrain from checking scheme
, but check for some degree of similarity between the netloc
values?
--rewrite-assets
option fromstac_to_dc