Fix Python versions #587
Fix Python versions #587
Conversation
tests/test-env-py39.yml
Outdated
| @@ -46,7 +46,7 @@ dependencies: | |||
| - pytest-httpserver | |||
| - pytest-cov | |||
| - pytest-timeout | |||
| - moto | |||
| - moto[server] | |||
There was a problem hiding this comment.
not valid conda syntax, this only works with pip, unless something changed recently in conda
There was a problem hiding this comment.
Yeah, I had a feeling that was the case. I've installed conda and I'll deal with it tomorrow.
There was a problem hiding this comment.
It's the moto version that's the issue - conda is pulling in an ancient version for some reason.
There was a problem hiding this comment.
Lol. I just removed the ancient pin on aiobotocore and it built in 1/5 the time and works fine.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #587 +/- ##
============================================
+ Coverage 56.22% 66.55% +10.32%
============================================
Files 47 65 +18
Lines 4016 5367 +1351
============================================
+ Hits 2258 3572 +1314
- Misses 1758 1795 +37
☔ View full report in Codecov by Sentry. |
| @@ -49,7 +49,6 @@ dependencies: | |||
| - moto | |||
| - deepdiff | |||
|
|
|||
|
|
|||
| # for docs | |||
| - sphinx | |||
There was a problem hiding this comment.
Don't do it now, but, omg, testing everywhere is such a mess. I'm sure we don't need sphinx here...
| @@ -28,7 +28,7 @@ jobs: | |||
| - name: Setup Python | |||
| uses: actions/setup-python@v1 | |||
| with: | |||
| python-version: 3.8 | |||
| python-version: 3.9 | |||
There was a problem hiding this comment.
At some point, we should use the GitHub actions matrix to parameterise this and test more than a single Python version.
Updated supported Python version to >= 3.9 throughout.
Updated test conda environment to Python 3.9
Pinned odc_apps_dc_tools to Python 3.9-3.10 as per opendatacube/datacube-core#1511