Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update archive_less_mature option to expect int value #579

Merged
merged 8 commits into from
Oct 11, 2023
Merged

update archive_less_mature option to expect int value #579

merged 8 commits into from
Oct 11, 2023

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented Oct 9, 2023

To allow for timestamp discrepancies between dataset versions, archive_less_mature in core now expects an optional int value instead of a boolean. Update the --archive-less-mature click option and index_update_dataset to reflect this.

SpacemanPaul
SpacemanPaul approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for dealing with this.

@SpacemanPaul SpacemanPaul merged commit b66a126 into develop Oct 11, 2023
6 checks passed
@SpacemanPaul SpacemanPaul deleted the update_alm_option branch October 11, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpacemanPaul SpacemanPaul SpacemanPaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ariana-B @SpacemanPaul