Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ls4-7 band aliases #313

Merged
merged 10 commits into from
Dec 5, 2023
Merged

Update ls4-7 band aliases #313

merged 10 commits into from
Dec 5, 2023

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented Dec 4, 2023

Recently downloaded ls7 l1 c2 scenes crash Landsat packaging during the yaml generation phase due to updated band mappings in new collection. Add missing band aliases to mapping.
Also update github actions in docker workflow, and update pystac and jsonschema versions.

@jeremyh
Copy link
Collaborator

jeremyh commented Dec 4, 2023

Thanks for looking into this Ariana!

It looks like the test failures are unrelated to the change. A dependency may have broken:

self = <pystac.validation.stac_validator.JsonSchemaSTACValidator object at 0x7fd31a235f40>
schema_uri_map = None

    def __init__(self, schema_uri_map: Optional[SchemaUriMap] = None) -> None:
        if not HAS_JSONSCHEMA:
>           raise ImportError("Cannot instantiate, requires jsonschema package")
E           ImportError: Cannot instantiate, requires jsonschema package

dunkgray
dunkgray previously approved these changes Dec 4, 2023
Copy link
Contributor

@dunkgray dunkgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Ariana-B Ariana-B marked this pull request as ready for review December 5, 2023 02:36
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d4a391) 84.78% compared to head (2be9b43) 84.78%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #313   +/-   ##
========================================
  Coverage    84.78%   84.78%           
========================================
  Files           26       26           
  Lines         4410     4410           
========================================
  Hits          3739     3739           
  Misses         671      671           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ariana-B
Copy link
Contributor Author

Ariana-B commented Dec 5, 2023

@jeremyh tests are passing now

Copy link
Collaborator

@jeremyh jeremyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — nice work

@Ariana-B Ariana-B merged commit 3baedc2 into develop Dec 5, 2023
8 checks passed
@Ariana-B Ariana-B deleted the update_band_mappings branch December 5, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants