-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ls4-7 band aliases #313
Conversation
Thanks for looking into this Ariana! It looks like the test failures are unrelated to the change. A dependency may have broken:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #313 +/- ##
========================================
Coverage 84.78% 84.78%
========================================
Files 26 26
Lines 4410 4410
========================================
Hits 3739 3739
Misses 671 671 ☔ View full report in Codecov by Sentry. |
@jeremyh tests are passing now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good — nice work
Recently downloaded ls7 l1 c2 scenes crash Landsat packaging during the yaml generation phase due to updated band mappings in new collection. Add missing band aliases to mapping.
Also update github actions in docker workflow, and update pystac and jsonschema versions.