-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for multiple locations from postgis index #1658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but let's make the migration a proper migration.
datacube/drivers/postgis/alembic/versions/d27eed82e1f6_remove_datasetlocation_table.py
Show resolved
Hide resolved
datacube/drivers/postgis/alembic/versions/d27eed82e1f6_remove_datasetlocation_table.py
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1658 +/- ##
===============================================
+ Coverage 85.22% 85.56% +0.34%
===============================================
Files 144 143 -1
Lines 15787 15418 -369
===============================================
- Hits 13454 13192 -262
+ Misses 2333 2226 -107 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, once mypy and precommit checks pass.
Reason for this pull request
Rather than simply deprecating, remove multiple location support entirely from the postgis index. Related deprecated methods are either no-ops or only work with a single location.
Also remove unnecessary and unused code previously copied over from eo-datasets (no impact).
Proposed changes
Delete
DatasetLocation
table and integrate uri data into theDataset
tableError if attempting to
add
orupdate
a dataset with multiple locationsAlter deprecated location methods to only work with one location
Closes #xxxx
Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes📚 Documentation preview 📚: https://datacube-core--1658.org.readthedocs.build/en/1658/