Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for multiple locations from postgis index #1658

Merged
merged 10 commits into from
Nov 21, 2024

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented Nov 15, 2024

Reason for this pull request

Rather than simply deprecating, remove multiple location support entirely from the postgis index. Related deprecated methods are either no-ops or only work with a single location.
Also remove unnecessary and unused code previously copied over from eo-datasets (no impact).

Proposed changes

  • Delete DatasetLocation table and integrate uri data into the Dataset table

  • Error if attempting to add or update a dataset with multiple locations

  • Alter deprecated location methods to only work with one location

  • Closes #xxxx

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes


📚 Documentation preview 📚: https://datacube-core--1658.org.readthedocs.build/en/1658/

@Ariana-B Ariana-B marked this pull request as ready for review November 19, 2024 04:42
Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's make the migration a proper migration.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 20 lines in your changes missing coverage. Please review.

Project coverage is 85.56%. Comparing base (015ddae) to head (a01d968).
Report is 11 commits behind head on develop-1.9.

Files with missing lines Patch % Lines
...sions/d27eed82e1f6_remove_datasetlocation_table.py 53.84% 12 Missing ⚠️
datacube/index/postgis/_datasets.py 80.00% 6 Missing ⚠️
datacube/drivers/postgis/_api.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1658      +/-   ##
===============================================
+ Coverage        85.22%   85.56%   +0.34%     
===============================================
  Files              144      143       -1     
  Lines            15787    15418     -369     
===============================================
- Hits             13454    13192     -262     
+ Misses            2333     2226     -107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, once mypy and precommit checks pass.

@Ariana-B Ariana-B merged commit 009a9f2 into develop-1.9 Nov 21, 2024
30 checks passed
@Ariana-B Ariana-B deleted the remove_postgis_locs branch November 21, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants