Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update Go 1.21 support #202

Merged
merged 4 commits into from
Aug 14, 2023
Merged

ci: update Go 1.21 support #202

merged 4 commits into from
Aug 14, 2023

Conversation

michalbiesek
Copy link
Contributor

No description provided.

thaJeztah
thaJeztah reviewed Aug 14, 2023
View reviewed changes
.github/workflows/validate.yml Outdated
@@ -33,7 +33,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: 1.20.x
go-version: 1.21.x
- uses: golangci/golangci-lint-action@v3
with:
version: v1.51
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to update golangci-lint as well, as go1.21 support was added in v1.54; https://github.com/golangci/golangci-lint/releases/tag/v1.54.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@thaJeztah
Copy link
Member

Looks like the updated linter doesn't like the unused (but named) arguments in the stubs.

I guess we can either update the linter settings (in golangci-lint.yml) or remove the names

Not sure what's best here; having the names could still be useful to understand the arguments that are passed to the stubs, but perhaps that's not a big issue;

  Warning: unused-parameter: parameter 'options' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'options' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'path' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fileLabel' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'path' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fpath' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'class' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fpath' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fpath' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fpath' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fpath' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'pid' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'val' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'source' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'sourceRange' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fd' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'mode' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'label' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'val' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'src' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'fpath' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'src' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'user' seems to be unused, consider removing or renaming it as _ (revive)

@rhatdan
Copy link
Collaborator

rhatdan commented Aug 14, 2023

LGTM
Thanks @michalbiesek
Could you make the suggested changes to the stub functions.

@michalbiesek
Copy link
Contributor Author

@rhatdan
Done. I have removed the unused parameters.

thaJeztah
thaJeztah approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy 😄

thanks!

@thaJeztah
Copy link
Member

@rhatdan could you re-LGTM this one?

@thaJeztah thaJeztah mentioned this pull request Aug 14, 2023
Merged
@rhatdan
Copy link
Collaborator

rhatdan commented Aug 14, 2023

LGTM

@rhatdan rhatdan merged commit b809725 into opencontainers:main Aug 14, 2023
11 checks passed
@michalbiesek michalbiesek deleted the feat-go-1.21 branch August 14, 2023 17:30
@michalbiesek
Copy link
Contributor Author

@thaJeztah @rhatdan just FYI: The new CI jobs for Go 1.21.x are not marked as required.
Screenshot from 2023-08-14 19-35-46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@kolyshkin kolyshkin Awaiting requested review from kolyshkin kolyshkin is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalbiesek @thaJeztah @rhatdan