CERTZ2.1 server_certificates #3313
Open
+977
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #3313 / ead1573Virtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 12004335795Details
💛 - Coveralls |
robshakir
requested changes
Jul 22, 2024
feature/security/gnsi/certz/tests/internal/setup_service/setup_service.go
Outdated
Show resolved
Hide resolved
feature/security/gnsi/certz/tests/internal/setup_service/setup_service.go
Outdated
Show resolved
Hide resolved
| } | ||
| rotateResponse := &certzpb.RotateCertificateResponse{} | ||
| for i := 0; i < 20; i++ { | ||
| rotateResponse, err = rotateRequestClient.Recv() |
There was a problem hiding this comment.
Recv here is blocking -- so you don't need to do this. If you're wanting something like a maximum wait time here you need to do something like having a goroutine that sits calling Recv, and one that subsequently cancels it after a timeout. An example is shown below.
There was a problem hiding this comment.
Did this comment make sense, please let me know if you'd like to discuss it further.
feature/security/gnsi/certz/tests/internal/setup_service/setup_service.go
Outdated
Show resolved
Hide resolved
feature/security/gnsi/certz/tests/internal/setup_service/setup_service.go
Outdated
Show resolved
Hide resolved
feature/security/gnsi/certz/tests/internal/setup_service/setup_service.go
Outdated
Show resolved
Hide resolved
feature/security/gnsi/certz/tests/internal/setup_service/setup_service.go
Outdated
Show resolved
Hide resolved
feature/security/gnsi/certz/tests/internal/setup_service/setup_service.go
Show resolved
Hide resolved
feature/security/gnsi/certz/tests/server_certificates/server_certificates_test.go
Outdated
Show resolved
Hide resolved
feature/security/gnsi/certz/tests/server_certificates/server_certificates_test.go
Outdated
Show resolved
Hide resolved
|
Thanks for this test case -- it looks to cover the |
|
/gcbrun |
robshakir
reviewed
Aug 2, 2024
feature/security/gnsi/certz/tests/internal/setup_service/setup_service.go
Outdated
Show resolved
Hide resolved
feature/security/gnsi/certz/tests/internal/setup_service/setup_service.go
Show resolved
Hide resolved
feature/security/gnsi/certz/tests/internal/setup_service/setup_service.go
Outdated
Show resolved
Hide resolved
feature/security/gnsi/certz/tests/internal/setup_service/setup_service.go
Outdated
Show resolved
Hide resolved
| } | ||
| rotateResponse := &certzpb.RotateCertificateResponse{} | ||
| for i := 0; i < 20; i++ { | ||
| rotateResponse, err = rotateRequestClient.Recv() |
There was a problem hiding this comment.
Did this comment make sense, please let me know if you'd like to discuss it further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CERTZ2.1 server_certificates testcase
CERTZ2.2 server_certificates testcase