-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update nightly-testing-2024-12-23 #908
Conversation
All good. Thank you for looking into this. When updating mathlib, it makes sense to update incrementally to individual releases as this will (a) make |
sure, then I'm happy to help with #907 and then come back to this one! |
There is just one issue with |
I am surprised this is an issue at all. Afaiu I lean itself nothing changed. So I am unsure how this proof must now be different. Did sth in Mathlib change? |
There were some changes made to |
but I don't see how that would impact the definition (https://github.com/leanprover-community/mathlib4/compare/nightly-testing-2024-12-21...nightly-testing-2024-12-23?diff=split&w=#diff-eeee6783198a232a3a9566d67c87f0073ac7b01bf79f0db8cdd5580d8497bbe8) |
@luisacicolini It was renamed to |
|
Alive Statistics: 90 / 93 (3 failed) |
This is expected. :-) I should disable the error. (These timeouts are orthogonal) |
Alive Statistics: 90 / 93 (3 failed) |
WIP. integrating changes from #907 too - cc @tobiasgrosser: sorry i did not see #907 existed already when i started working on this