Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update nightly-testing-2024-12-23 #908

Merged
merged 7 commits into from
Dec 26, 2024
Merged

Conversation

luisacicolini
Copy link
Contributor

WIP. integrating changes from #907 too - cc @tobiasgrosser: sorry i did not see #907 existed already when i started working on this

@tobiasgrosser
Copy link
Collaborator

All good. Thank you for looking into this. When updating mathlib, it makes sense to update incrementally to individual releases as this will (a) make git bisect easier and (b) allows us to fix one issue at a time. I will add some comments what I am currently struggling with in #907.

@luisacicolini
Copy link
Contributor Author

sure, then I'm happy to help with #907 and then come back to this one!

@luisacicolini
Copy link
Contributor Author

There is just one issue with rfl in FormulaToAuto/Language.mem_setOf_eq. Working on it.

@tobiasgrosser
Copy link
Collaborator

I am surprised this is an issue at all. Afaiu I lean itself nothing changed. So I am unsure how this proof must now be different. Did sth in Mathlib change?

@luisacicolini
Copy link
Contributor Author

luisacicolini commented Dec 26, 2024

There were some changes made to Language.lean in Mathlib, indeed

@bollu
Copy link
Collaborator

bollu commented Dec 26, 2024

@luisacicolini It was renamed to Language.instMembershipList. Oh the joy of auto-implicits, where instMembershipListLanguage was now a variable, which lean didn't know how to make head or tails of :)

@bollu
Copy link
Collaborator

bollu commented Dec 26, 2024

subprocess.TimeoutExpired: Command 'lake lean /home/tobiascgrosser/actions-runner/_work/lean-mlir/lean-mlir/SSA/Projects/InstCombine/tests/proofs/gsubhfromhsub_proof.lean' timed out after 1800 seconds

Copy link

Alive Statistics: 90 / 93 (3 failed)

@tobiasgrosser tobiasgrosser marked this pull request as ready for review December 26, 2024 14:26
@tobiasgrosser
Copy link
Collaborator

tobiasgrosser commented Dec 26, 2024

subprocess.TimeoutExpired: Command 'lake lean /home/tobiascgrosser/actions-runner/_work/lean-mlir/lean-mlir/SSA/Projects/InstCombine/tests/proofs/gsubhfromhsub_proof.lean' timed out after 1800 seconds

This is expected. :-) I should disable the error. (These timeouts are orthogonal)

Copy link

Alive Statistics: 90 / 93 (3 failed)

@tobiasgrosser tobiasgrosser added this pull request to the merge queue Dec 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 26, 2024
@tobiasgrosser tobiasgrosser added this pull request to the merge queue Dec 26, 2024
Merged via the queue into main with commit 9ee49e0 Dec 26, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants