feat: Adapt the generic circuit based decision procedure for fixed-width #893
+141
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this didn't actually help, writing the code helped clarify my thinking. @tobiasgrosser , I'd appreciate a merge here, so I can move on to proving the correctness of the core algorithm from tomorrow ^_^ |
|
Sure, feel free to merge. |
|
Alive Statistics: 90 / 93 (3 failed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write a special variant of the generic width decision procedure that only works for a single fixed width. The key idea is to use the automata we have to 'accelerate', and simulate upto the fixed bitwidth (e.g.
64) and retrieve the result of the automata at that specific width.The cost is that each step, we consider all combinations of input bitwidths, which can make this somewhat to dramatically expensive. However, note that the entire decision procedure was not meant to deal with fixed width anyway, so it's pretty remarkable that we can do this at all...