Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IExpr -> Expr, ICom -> Com #122

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Rename IExpr -> Expr, ICom -> Com #122

merged 3 commits into from
Oct 26, 2023

Conversation

goens
Copy link
Collaborator

@goens goens commented Oct 26, 2023

As discussed on Zulip, since the "I" stands for intrinsic from the experiments and this is not an experiment anymore at this point.

goens added 3 commits October 26, 2023 16:36
@goens
Rename IExpr -> Expr, ICom -> Com
d7a25ce 
As discussed on Zulip, since the "I" stands for intrinsic from the
experiments and this is not an experiment anymore at this point.
@goens
Fix namespace clash in Transform
271b25f
@goens
Fix replace issue in EDSL
c8c3482
@alexkeizer
Copy link
Collaborator

The rename LGTM, assuming you get the build working again.
I noticed some changes in SSA/Experimental/ExtrinsicAsymptotics.lean as well, can we just get rid of this file, now that we've settled on the intrinsicly well-typed encoding?

@goens goens merged commit d7b9b08 into main Oct 26, 2023
1 check passed
@goens goens deleted the rename-icom-iexpr branch October 26, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goens @alexkeizer