-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compare.py which contains functions for comparing. #1206
base: devel
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #1206 +/- ##
==========================================
- Coverage 84.44% 83.52% -0.93%
==========================================
Files 66 67 +1
Lines 5511 5602 +91
Branches 1265 1289 +24
==========================================
+ Hits 4654 4679 +25
- Misses 557 617 +60
- Partials 300 306 +6 ☔ View full report in Codecov by Sentry. |
Added test for everything in reactions except annotation, notes
Added test for everything in reactions Added test for ignore_keys in reactions Made annotation resettable
added metabolite comparison tests
…for test_io_order.py
…code style for test_notes.py
… test_annotation.py
… test_annotation_format.py
…ode style for test_core/conftest.py
…g for solution.py
) -> Tuple[bool, Dict]: | ||
"""Cmpare two cobra Objects (including subclasses). | ||
|
||
Useful for Metaboite, and Gene Comparison. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo Metaboite
I'm a bit unsure if this should be in the cobrapy package, part of a cookbook, or possibly a cobra-tools package or so. Let's discuss at the dev meeting! |
Since the test suite is now separated, maybe this could also live there? There is some value to have it for testing purposes... |
I'd be happy to move it to the testing suite. This really helped me working on MAT import to make sure it is the same as SBML. |
Would you like me to move the compare function to tests? I can do that. |
Added functions for comparing models, metabolites, reactions, groups, genes. This is an adaptation of a function I used to compare XML and MAT models of the same file.
I'm not sure what tests to add for this. Maybe we can replace the test.test_io.conftest.py compare_mdoels() function with this one.