app: Fix migration EnsureSampleIndexConfigurationIsAlwaysDefined. #TA…

…SK-6765
opencb · Sep 11, 2024 · b663722 · b663722
1 parent a4b75fa
commit b663722
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/...encga/app/migrations/v3/v3_4_0/storage/EnsureSampleIndexConfigurationIsAlwaysDefined.java b/...encga/app/migrations/v3/v3_4_0/storage/EnsureSampleIndexConfigurationIsAlwaysDefined.java
@@ -1,5 +1,6 @@
 package org.opencb.opencga.app.migrations.v3.v3_4_0.storage;
 
+import org.apache.commons.collections4.CollectionUtils;
 import org.opencb.opencga.app.migrations.StorageMigrationTool;
 import org.opencb.opencga.catalog.migration.Migration;
 import org.opencb.opencga.core.config.storage.SampleIndexConfiguration;
@@ -27,15 +28,19 @@ protected void run() throws Exception {
             if (engine.getMetadataManager().exists()) {
                 for (Integer studyId : engine.getMetadataManager().getStudyIds()) {
                     StudyMetadata studyMetadata = engine.getMetadataManager().getStudyMetadata(studyId);
-                    List<StudyMetadata.SampleIndexConfigurationVersioned> configurations = studyMetadata.getSampleIndexConfigurations();
-                    if (configurations == null || configurations.isEmpty()) {
-                        configurations = new ArrayList<>(1);
-                        logger.info("Creating default SampleIndexConfiguration for study '" + studyMetadata.getName() + "' (" + studyId + ")");
-                        configurations.add(new StudyMetadata.SampleIndexConfigurationVersioned(
-                                preFileDataConfiguration(),
-                                StudyMetadata.DEFAULT_SAMPLE_INDEX_VERSION,
-                                Date.from(Instant.now()), StudyMetadata.SampleIndexConfigurationVersioned.Status.ACTIVE));
-                        studyMetadata.setSampleIndexConfigurations(configurations);
+                    if (CollectionUtils.isEmpty(studyMetadata.getSampleIndexConfigurations())) {
+                        engine.getMetadataManager().updateStudyMetadata(studyId, sm -> {
+                            if (CollectionUtils.isEmpty(sm.getSampleIndexConfigurations())) {
+                                List<StudyMetadata.SampleIndexConfigurationVersioned> configurations = new ArrayList<>(1);
+                                logger.info("Creating default SampleIndexConfiguration for study '" + studyMetadata.getName() + "'"
+                                        + " (" + studyId + ")");
+                                configurations.add(new StudyMetadata.SampleIndexConfigurationVersioned(
+                                        preFileDataConfiguration(),
+                                        StudyMetadata.DEFAULT_SAMPLE_INDEX_VERSION,
+                                        Date.from(Instant.now()), StudyMetadata.SampleIndexConfigurationVersioned.Status.ACTIVE));
+                                sm.setSampleIndexConfigurations(configurations);
+                            }
+                        });
                     }
                 }
             }

diff --git a/opencga-catalog/src/main/java/org/opencb/opencga/catalog/migration/MigrationManager.java b/opencga-catalog/src/main/java/org/opencb/opencga/catalog/migration/MigrationManager.java
@@ -239,7 +239,8 @@ private MigrationSummary getMigrationSummary(String organizationId) throws Catal
                         p -> p.getValue().getStatus(),
                         () -> new EnumMap<>(MigrationRun.MigrationStatus.class),
                         Collectors.counting())))
-                .setVersionCount(runs.stream().collect(Collectors.groupingBy(p -> p.getKey().version(), Collectors.counting())));
+                .setVersionCount(runs.stream().collect(Collectors.groupingBy(p -> p.getKey().version(),
+                        TreeMap::new, Collectors.counting())));
 
         long toBeApplied = migrationSummary
                 .getStatusCount()