REFACTOR Caching #16
Open
REFACTOR Caching #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmirnow
requested changes
Nov 9, 2020
| @@ -20,8 +20,11 @@ adapter.invalid-publication-channels=internal | |||
| # opencast.external-api.uri=https://{organization}.api.opencast.com | |||
| # opencast.external-api.user=admin | |||
| # opencast.external-api.password=password | |||
| # opencast.external-api.max-cache-size=1000 | |||
| # opencast.external-api.cache-expiration-duration=PT0M | |||
| ##Cache duration. When set to PT0M, cache is disabled. Min. Caching is one minute. | |||
There was a problem hiding this comment.
What is the minimum cache time? Does PT0M disables the caching or not?
| cacheDir = new File(opencastCacheDir); | ||
| } | ||
|
|
||
| long cacheSize = Long.valueOf(parsed.getProperty(OPENCAST_CACHE_SIZE,"10")) * 1024 * 1024; |
There was a problem hiding this comment.
The configuration set 50MB per default. We have to choose one, 10 or 50 but same default value.
There was a problem hiding this comment.
I have matched this line to the default value.
|
|
||
| private int maxAge; | ||
|
|
||
| public CacheInterceptor(int maxAge) { |
There was a problem hiding this comment.
Please ducument the argument what int does mean here.
There was a problem hiding this comment.
I added a comment to explain the argument.
| Response response = chain.proceed(chain.request()); | ||
|
|
||
| CacheControl cacheControl = new CacheControl.Builder() | ||
| .maxAge(this.maxAge, TimeUnit.MINUTES) |
There was a problem hiding this comment.
Does PT0M work with this? Or do we need an edge case with CacheControl.Builder#noStore()
berthob98
force-pushed
the
r5199_fix_caching
branch
from
81b2e9d
to
89ffa51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #15.
Details:
Instead of caching in the Reactive Stream layer we use the caching facilities of
OkHttpClient. The behaviour differs from the former implementation in