vcp from vospace works when system in readonly mode (CADC 13277)
#218
Conversation
| echo -n "Follow the invalid link and fail" | ||
| $CPCMD $CERT $CONTAINER/e3link/somefile /tmp >& /dev/null && echo " [FAIL]" && exit -1 | ||
| $CPCMD $CERT $CONTAINER/e3link/somefile /tmp >& /dev/null && echo " [FAIL]" && exit - |
There was a problem hiding this comment.
Is the 1 removed on purpose?
There was a problem hiding this comment.
The file looks fine to me. It think it's a diff issue maybe
vos/vos/vos.py
Outdated
| get_urls = self.get_node_url(source, method='GET', | ||
| cutout=cutout, view=view, | ||
| full_negotiation=True) | ||
| # remove the first one as we already tried that one. | ||
| get_urls.pop(0) | ||
| # one of the ur |
There was a problem hiding this comment.
I'm not sure what the comment is trying to say - it could just be removed?
vos/vos/vos.py
Outdated
| @@ -2711,12 +2700,13 @@ def update(self, node, recursive=False): | |||
| try: | |||
| property_url = endpoints.recursive_props | |||
| except KeyError as ex: | |||
| property_url = endpoints.p | |||
There was a problem hiding this comment.
Does this line have any effect?
| $LOCKCMD $CERT $CONTAINER $VUNLOCK_ARGS > /dev/null || echo " [FAIL]" && exit -1 | ||
| echo " [OK]" | ||
| echo -n "check unlocked container " | ||
| echo "$TAGCMD $CERT $CONTAINER $LIST_ARGS" | ||
| $TAGCMD $CERT $CONTAINER $LIST_ARGS | grep -q false && set SUCCESS = "true" | ||
| $TAGCMD $CERT $CONTAINER $LIST_ARGS | grep -q None && set SUCCESS = "true" |
There was a problem hiding this comment.
The grep -q false changed to grep -q None in the $TAGCMD executions, but the grep -q true stayed the same in other execution checks. Is that consistent with the service behaviour?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
==========================================
+ Coverage 61.33% 62.14% +0.81%
==========================================
Files 21 21
Lines 2664 2692 +28
==========================================
+ Hits 1634 1673 +39
+ Misses 1030 1019 -11 ☔ View full report in Codecov by Sentry. |
Changed
vosto first try thefilesend point withPullFromVospace. That avoids creating a job, a step that now fails whenvaultis in ReadOnly mode.Also added temporary code to make cutout work with the current VOSpace services.