chore: handle all UnhandledMatchErrors #467
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR. In my opinion, it would be better to handle the types properly instead of throwing an exception. The problem is, that according to the specs, there shouldn't be a different type. Could you please provide some steps to reproduce the issue? |
|
@gehrisandro sorry for later reply. And unfortunately we can not reproduce the issue easily, we only occasionally see this error in our sentry platform (https://www.sentry.io), but the sentry doesn't record what http response was actually received, so I can't give you any further debug information. So my intention of this PR is to use the new Exception to allow the sentry to record the unprocessed type content, so that it can be continuously corrected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Our sentry has been logged many times UnhandledMatchError with class ThreadRunStepResponseToolCallsStepDetails.
So this PR try to throw wrapped exception like ThreadRunStreamResponse does for all matches.
Related:
N/A