Spec query use bconf #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1b3d2ee. Using --no-conditionals can break macro expansion. For instance, if we have a spec file like this %if ... %define foo 123 %else %define foo 456 %endif then %{foo} always expands to 456 (in case of the 70-baselibs script this is usually not what we want).
Without a buildconfig, macros like %suse_version etc. are not defined, which yields to wrong results (see, for instance, openSUSE@1b3d2ee#commitcomment-28049342). By default, we use /usr/lib/build/configs/sl15.5.conf. Moreover, a "--config" option is added to override the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues mentioned in 1b3d2ee#commitcomment-28049342
The question is which buildconfig we should use. For now, we use /usr/lib/build/configs/sl15.5.conf,
but this (of course) has already an outdated suse_version macro (wrt. factory).
Alternatively, we could always fetch the latest factory buildconfig from the obs... (assumptions:
internet access is possible and the source_validator is only used for factory)
@DimStar77, @bugfinder and others: any opinions?:)