ThemeChanging Functionality Added #2723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyajali
requested changes
Dec 22, 2024
core/datastore/src/main/java/org/mifos/mobile/core/datastore/PreferencesHelper.kt
Outdated
Show resolved
Hide resolved
|
@niyajali i have done the changes you told. Review it once |
niyajali
requested changes
Dec 25, 2024
|
@niyajali used edgeToedge API instead of window API can you review it once |
niyajali
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
@revanthkumarJ Looks good to me, should be merged, and can you upload the latest video/image.
Status Bar Current Images
Theme Changing Current VideoWhatsApp.Video.2024-12-27.at.2.17.28.AM.mp4 |
|
@therajanmaurya sir , i have done all the changes told by niyaj bro and the theme functionality is working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #Issue_Number
Please Add Screenshots If there are any UI changes.
Before:
WhatsApp.Video.2024-12-22.at.2.05.59.PM.mp4
Now:
Record_2024-12-22-14-33-57_0b55964ac4df2babebf0d80487f8a230.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.