Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rules for a strong password #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RadheTians
Copy link
Contributor

@RadheTians RadheTians commented Dec 22, 2020

The set of rules is following. Fixes #83

  • At least 8 characters—the more characters, the better
  • A mixture of both uppercase and lowercase letters
  • A mixture of letters and numbers
  • Inclusion of at least one special character, e.g.,! @ # ? ]

ezgif com-video-to-gif(1)

@BLasan
Copy link

BLasan commented Dec 26, 2020

@RadheTians Shall we squash the two commits and send a PR containing only one commit ? @abhi40308 or else is it ok in this way?

@RadheTians
Copy link
Contributor Author

@BLasan I think there is no need to create another PR, there is a single line change between PRs due to the syntax checker.

@BLasan
Copy link

BLasan commented Dec 30, 2020

@BLasan I think there is no need to create another PR, there is a single line change between PRs due to the syntax checker.

yuh, no need to create another PR. You can just merge the two commits you have done into one commit and force push again. If it's needed @abhi40308 otherwise no problem of having two commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a set of rules for a strong password
2 participants