Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create index, destroy, show, edit and update route for programming groups #1906

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Create index, destroy, show, edit and update route for programming groups #1906

merged 4 commits into from
Oct 23, 2023

Conversation

kiragrammel
Copy link
Contributor

@kiragrammel kiragrammel commented Sep 14, 2023 •
edited
Loading

  • Add an index route for programming groups to have an overview for admins which groups exist
  • Add an destroy route for programming groups to delete groups and make it possible to start working with another person on a exercise or work alone
  • Add edit & update route for programming groups to remove users from a group
  • closes Add show route for programming_group #1848

@kiragrammel kiragrammel force-pushed the pp-index-route branch 2 times, most recently from 2ff52e0 to 9da0ba6 Compare September 14, 2023 15:07
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Merging #1906 (328d52e) into master (f1ca5da) will decrease coverage by 0.09%.
The diff coverage is 59.57%.

❗ Current head 328d52e differs from pull request most recent head 3de2bef. Consider uploading reports for the commit 3de2bef to get more accurate results

@@            Coverage Diff             @@
##           master    #1906      +/-   ##
==========================================
- Coverage   66.03%   65.94%   -0.09%     
==========================================
  Files         195      195              
  Lines        6103     6132      +29     
==========================================
+ Hits         4030     4044      +14     
- Misses       2073     2088      +15
Files Coverage Δ
app/helpers/statistics_helper.rb 100.00% <ø> (ø)
app/models/exercise.rb 60.52% <100.00%> (+0.20%) ⬆️
app/models/request_for_comment.rb 95.34% <100.00%> (+0.22%) ⬆️
app/policies/exercise_policy.rb 93.33% <100.00%> (+0.47%) ⬆️
app/policies/programming_group_policy.rb 100.00% <100.00%> (ø)
app/models/programming_group_membership.rb 80.00% <50.00%> (-7.50%) ⬇️
app/models/user.rb 86.56% <50.00%> (ø)
app/models/programming_group.rb 85.24% <75.00%> (-2.69%) ⬇️
app/controllers/programming_groups_controller.rb 28.57% <36.36%> (+3.57%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kiragrammel kiragrammel force-pushed the pp-index-route branch 3 times, most recently from 34ddb85 to b887728 Compare September 15, 2023 09:44
MrSerth

This comment was marked as resolved.

Sign in to view

@kiragrammel kiragrammel marked this pull request as ready for review September 19, 2023 15:18
MrSerth
MrSerth reviewed Sep 22, 2023
View reviewed changes
app/models/exercise.rb Outdated Show resolved Hide resolved
@MrSerth

This comment was marked as resolved.

Sign in to view
@kiragrammel kiragrammel changed the title Create index & destroy route for programming groups Create index, destroy, show, edit and update route for programming groups Sep 28, 2023
MrSerth
MrSerth reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some pending comments I already made last week (but didn't submit).

app/views/study_groups/_form.html.slim Outdated Show resolved Hide resolved
app/views/study_groups/show.html.slim Outdated Show resolved Hide resolved
config/locales/de.yml Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
@MrSerth

This comment was marked as resolved.

Sign in to view
MrSerth
MrSerth reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, these are the main, missing points. Nothing too big, only a few remarks. I am sure, we can proceed merging soon ™️

spec/policies/programming_group_policy_spec.rb Outdated Show resolved Hide resolved
config/routes.rb Outdated Show resolved Hide resolved
config/routes.rb Outdated Show resolved Hide resolved
config/locales/de.yml Outdated Show resolved Hide resolved
app/views/submissions/index.html.slim Show resolved Hide resolved
app/controllers/programming_groups_controller.rb Show resolved Hide resolved
app/controllers/programming_groups_controller.rb Outdated Show resolved Hide resolved
app/controllers/programming_groups_controller.rb Outdated Show resolved Hide resolved
app/models/programming_group.rb Show resolved Hide resolved
app/models/programming_group.rb Outdated Show resolved Hide resolved
@kiragrammel kiragrammel mentioned this pull request Oct 16, 2023
Open
@kiragrammel kiragrammel force-pushed the pp-index-route branch 2 times, most recently from 38d8c10 to c16b1f8 Compare October 22, 2023 13:50
@MrSerth

This comment was marked as resolved.

Sign in to view
@MrSerth

This comment was marked as resolved.

Sign in to view
@MrSerth

This comment was marked as resolved.

Sign in to view
kiragrammel and others added 4 commits October 23, 2023 18:03
@kiragrammel @MrSerth
Add CRUD operations for Programming Groups
ccad3af 
* Correct sorting in table
* Modify page when nested in exercises
* Fix links between pages
* Link from statistics page to programming_groups/index
* Link from submission page to programming_groups/<id>
* Allow filtering for exercise ID on ProgrammingGroup#index
* Add search fields for internal and external user id on pg/index
@MrSerth
Keep existing programming group memberships during update
fea9207
@kiragrammel @MrSerth
Generalize breadcrumbs for nested resources
cbaa6ca 
* Make programming groups breadcrumb navigation clickable
@MrSerth
Allow RfC index action for exercises to be nested
3de2bef
MrSerth
MrSerth approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, well done! 💪

@MrSerth MrSerth enabled auto-merge (rebase) October 23, 2023 16:06
@MrSerth MrSerth merged commit bbee854 into master Oct 23, 2023
6 checks passed
@MrSerth MrSerth deleted the pp-index-route branch October 23, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSerth MrSerth MrSerth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add show route for programming_group
2 participants
@kiragrammel @MrSerth