Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement #54 + New Clippy Lint #58

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Implement #54 + New Clippy Lint #58

merged 7 commits into from
Mar 21, 2024

Conversation

lquerel
Copy link
Contributor

@lquerel lquerel commented Mar 19, 2024

This PR implements #54 and adds the str_to_string Clippy lint. See below for an explanation of this rule.

The to_string method is also used on other types to convert them to a string. When called on a &str it turns the &str into the owned variant String, which can be better expressed with .to_owned().

@lquerel lquerel marked this pull request as ready for review March 19, 2024 17:53
@lquerel lquerel requested a review from jsuereth as a code owner March 19, 2024 17:53
@lquerel lquerel self-assigned this Mar 19, 2024
@lquerel lquerel added the enhancement New feature or request label Mar 19, 2024
@lquerel lquerel linked an issue Mar 19, 2024 that may be closed by this pull request
Helper function to ease attribute inheritance logic #54
Closed
@lquerel lquerel merged commit 5275c53 into open-telemetry:main Mar 21, 2024
13 checks passed
@lquerel lquerel deleted the code-clean-up branch April 4, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

Assignees

@lquerel lquerel

Labels
enhancement New feature or request
Projects
OTel Weaver Project
Status: Done
Milestone
Semantic Convention Registry Focus
Development

Successfully merging this pull request may close these issues.

Helper function to ease attribute inheritance logic
2 participants
@lquerel @jsuereth