-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check group id, metric name, and group name uniqueness #382
Conversation
@lquerel I think this is unblocked now if you can update the branch |
# Conflicts: # CHANGELOG.md # crates/weaver_resolver/data/registry-test-4-events/expected-registry.json # crates/weaver_resolver/data/registry-test-4-events/registry/mobile-events.yaml
…atest Rust toolchain
…tion severity warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
=======================================
+ Coverage 72.5% 73.0% +0.4%
=======================================
Files 49 49
Lines 3635 3711 +76
=======================================
+ Hits 2639 2710 +71
- Misses 996 1001 +5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
for (key, provenances) in keys { | ||
if provenances.len() > 1 { | ||
// Deduplicate the provenances. | ||
let provenances: HashSet<String> = provenances.into_iter().collect(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: You can use itertools to .unique
this when collector instead of forcing a hashset.
I think performance wise it's the same, just easier to read.
This PR detects duplications in the following semconv concepts:
Since there are existing duplications in the current registries (see the example below), we return warnings instead of errors. As usual, the
--future
flag must be used for future versions of the registry.Example: https://github.com/search?q=repo%3Aopen-telemetry%2Fsemantic-conventions+path%3A%2F%5Emodel%5C%2F%2F+feature_flag&type=code
For now, the group name duplication detection is disabled.
Closes #306