Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Laurent Quérel <[email protected]>
  • Loading branch information
Leo6Leo and lquerel authored Nov 23, 2024
1 parent fd07908 commit 38154d6
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/registry/check.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ pub struct RegistryCheckArgs {
#[command(flatten)]
pub diagnostic: DiagnosticArgs,

/// Weaver parameters
/// Common weaver registry parameters
#[command(flatten)]
pub common_registry_args: CommonRegistryArgs,
}
Expand Down
2 changes: 1 addition & 1 deletion src/registry/generate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ pub struct RegistryGenerateArgs {
#[command(flatten)]
pub diagnostic: DiagnosticArgs,

/// Weaver parameters
/// Common weaver registry parameters
#[command(flatten)]
pub common_registry_args: CommonRegistryArgs,
}
Expand Down
4 changes: 2 additions & 2 deletions src/registry/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ pub fn semconv_registry(log: impl Logger + Sync + Clone, command: &RegistryComma
}
}

/// Set of Parameters used to specify the extra options for the `weaver` command.
/// The CommonRegistryArgs will be shared across all commands. So only the general options should be
/// Set of Parameters used to specify the extra options for the `weaver registry` command.
/// The CommonRegistryArgs will be shared across all `weaver registry` sub-commands. So only the general options should be
/// included here.
#[derive(Args, Debug)]
pub struct CommonRegistryArgs {
Expand Down
2 changes: 1 addition & 1 deletion src/registry/resolve.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ pub struct RegistryResolveArgs {
#[command(flatten)]
pub diagnostic: DiagnosticArgs,

// Weaver parameters
// Common weaver registry parameters
#[command(flatten)]
pub common_registry_args: CommonRegistryArgs,
}
Expand Down
2 changes: 1 addition & 1 deletion src/registry/search.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ pub struct RegistrySearchArgs {
/// Otherwise, runs an interactive terminal UI.
pub search_string: Option<String>,

/// Weaver parameters
/// Common weaver registry parameters
#[command(flatten)]
pub common_registry_args: CommonRegistryArgs,
}
Expand Down
2 changes: 1 addition & 1 deletion src/registry/stats.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ pub struct RegistryStatsArgs {
#[command(flatten)]
pub diagnostic: DiagnosticArgs,

/// Weaver parameters
/// Common weaver registry parameters
#[command(flatten)]
pub common_registry_args: CommonRegistryArgs,
}
Expand Down
2 changes: 1 addition & 1 deletion src/registry/update_markdown.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ pub struct RegistryUpdateMarkdownArgs {
#[command(flatten)]
pub diagnostic: DiagnosticArgs,

/// Weaver parameters
/// Common weaver registry parameters
#[command(flatten)]
pub common_registry_args: CommonRegistryArgs,
}
Expand Down

0 comments on commit 38154d6

Please sign in to comment.