Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change azure_ to az. in cloud.platform enum values on #1698

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Dec 18, 2024

Azure-specific attributes/signals use az. prefix to denote they belong to az namespace:

We also use az. prefix/namespace in az.ai.inference (gen.ai.system enum value)

I'd like to try and consolidate cloud.platform enum values.

TODO: check with other MS folks and check existing usages to see how breaking it would be:

  • azure_aks -> az.aks
  • azure_app_service -> az.app_service
  • azure_container_apps -> az.container_apps
  • azure_container_instances -> az.container_instances
  • azure_functions -> az.functions
  • azure_openshift -> az.openshift
  • azure_vm -> az.vm

Related to #1684 (comment), #608

PS: I'd encourage similar renames for AWS and GCP, but I have no means to check how much pain it would cause.

Merge requirement checklist

@lmolkova
Copy link
Contributor Author

lmolkova commented Dec 18, 2024

/cc @trask, @mattmccleary, @rajkumar-rangaraj, @cijothomas, @lzchen @RohitRanjanMS, @OsvaldoRosado, @reyang if the have any context on how breaking they expect it to be.

@lmolkova lmolkova changed the title Change azure_ to az. in enum values Change azure_ to az. in cloud.platform enum values on Dec 18, 2024
@RohitRanjanMS
Copy link

Thanks, @lmolkova . Functions is still in its early stages with respect to OTel, and I don't see any issues with this proposal.

@lzchen
Copy link

lzchen commented Dec 19, 2024

We do have azure resource detector that use some of these values although the component itself is experimental. In azmon exporter, we currently do not map resource attributes to telemetry custom dimensions BUT we do populate OTELRESOURCE custom metric which is populated with the resource attribute information. I believe this feature is in preview as well so probably not an issue to make breaking changes.

@jeremydvoss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants