Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add x-amzn-requestid as source for aws.request_id #1691

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Dec 17, 2024

Changes

The response headers used by AWS SDK are x-amzn-requestid, x-amzn-request-id or x-amz-request-id.

see e.g. here and here or here.

Merge requirement checklist

@Flarna Flarna requested review from a team as code owners December 17, 2024 12:43
model/aws/registry.yaml Outdated Show resolved Hide resolved
The response headers used by AWS SDK are `x-amzn-requestid`, `x-amzn-request-id` or `x-amz-request-id`.
@Flarna Flarna changed the title [chore] Correct x-amz-requestid to x-amzn-requestid [chore] Add x-amzn-requestid as source for aws.request_id Dec 18, 2024
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmolkova lmolkova merged commit 3d4013d into open-telemetry:main Dec 19, 2024
14 checks passed
@Flarna Flarna deleted the aws-request-id branch December 19, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants