-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Update vertex_ai to vertex.ai #1684
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
# | ||
# If your change doesn't affect end users you should instead start | ||
# your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: deprecation | ||
|
||
# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
component: gen_ai | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Update vertex_ai to vertex.ai | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
# The values here must be integers. | ||
issues: [1684] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,9 +13,9 @@ groups: | |
stability: experimental | ||
value: "openai" | ||
brief: 'OpenAI' | ||
- id: vertex_ai | ||
- id: vertex.ai | ||
stability: experimental | ||
value: "vertex_ai" | ||
value: "vertex.ai" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can't find any evidence of just "Vertex" without "AI" in GCP's docs, so If that reasoning holds water to keep it as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While we're here, should we prefix with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1, we can name it as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we're really inconsistent in semconv on prefixing things with cloud name (not intentionally). General issue - #608 E.g. we have Both So what should we do:
Speaking from Azure side, we're likely to stay where we are: cc @jsuereth if he has any thoughts There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's also the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm like 80% confident we can rename |
||
brief: 'Vertex AI' | ||
- id: anthropic | ||
stability: experimental | ||
|
@@ -37,6 +37,11 @@ groups: | |
stability: experimental | ||
value: "aws.bedrock" | ||
brief: 'AWS Bedrock' | ||
- id: vertex_ai | ||
stability: experimental | ||
value: "vertex_ai" | ||
brief: 'Deprecated. Use `vertex.ai` instead.' | ||
deprecated: "Replaced by `vertex.ai`." | ||
brief: The Generative AI product as identified by the client or server instrumentation. | ||
note: | | ||
The `gen_ai.system` describes a family of GenAI models with specific model identified | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmolkova do you know if we can also need to mark
vertex_ai
as deprecated? if so, how to make it? This is a value and not an attribute, did not find any example for this, thanks!