process: add process.status attribute #1212
Conversation
This PR deprecates `system.process.status` and replaces it with `process.status`. The previous usage of `system.process.status` has been replaced with `process.status`, and `process.status` has also been add as a resource attribute to the `process` resource.
| attribute_map: | ||
| system.process.status: process.status | ||
| apply_to_metrics: | ||
| - system.processes.count |
There was a problem hiding this comment.
Shouldn't we include all the other process metrics here?
There was a problem hiding this comment.
This attribute was only previously used on system.processes.count, so the rename in particular is only to that usage of the attribute. Its usage as a resource attribute is new, which means it doesn't get represented in this file (only renames not additive changes are in schema-next).
| examples: [ "idle", "interrupt" ] | ||
| - id: system.process.status | ||
| type: | ||
| allow_custom_values: true |
There was a problem hiding this comment.
nit
| allow_custom_values: true |
value is ignored and the flag will be removed at some point
| @@ -196,3 +196,23 @@ groups: | |||
| value: 'minor' | |||
| stability: experimental | |||
| stability: experimental | |||
| - id: status | |||
| type: | |||
| allow_custom_values: true | |||
There was a problem hiding this comment.
| allow_custom_values: true |
same here, value is ignored
| - ref: process.owner | ||
| - ref: process.status | ||
| requirement_level: | ||
| conditionally_required: See [Selecting process attributes](#selecting-process-attributes) for details. |
There was a problem hiding this comment.
I think Selecting process attributes applies to things that identify the process, I guess status is not one of them and would be recommended: when applicable or just recommended?
| @@ -8,6 +8,7 @@ groups: | |||
| - ref: process.pid | |||
| - ref: process.parent_pid | |||
| - ref: process.executable.name | |||
| - ref: process.owner | |||
There was a problem hiding this comment.
oops, this change resulted in changing requirement_level on process.executable.name.
|
Based on the discussion in SemConv SIG on 8/12, the only blocker is listing |
|
I could do that if it would help. I don't suspect anything in the |
* Remove ordering for attributes. * Fill in CHANGELOG link
* Remove ordering for attributes. * Fill in CHANGELOG link
|
Hey @braydonk, I wonder if this could be modeled as a metric instead. It was also suggested at #1032 (comment) and it seems it's already done for the |
|
This is going to be redone to model it the same as |
Related Issue: #1181
Changes
This PR deprecates
system.process.statusand replaces it withprocess.status. The previous usage ofsystem.process.statushas been replaced withprocess.status, andprocess.statushas also been add as a resource attribute to theprocessresource.Merge requirement checklist
[chore]