Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing heading ids on lang:ja #5584

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Add missing heading ids on lang:ja #5584

merged 3 commits into from
Nov 11, 2024

Conversation

katzchang
Copy link
Contributor

Fix for #5555 :

  • Explicitly specify some head ids
  • Remove ignore rules
ja/docs/zero-code/php/index.html
  hash does not exist --- ja/docs/zero-code/php/index.html --> /ja/docs/concepts/context-propagation/#propagation
ja/docs/languages/ruby/sampling/index.html
  hash does not exist --- ja/docs/languages/ruby/sampling/index.html --> /ja/docs/concepts/sampling#head-sampling
ja/docs/languages/erlang/sampling/index.html
  hash does not exist --- ja/docs/languages/erlang/sampling/index.html --> /ja/docs/concepts/sampling#head-sampling
  hash does not exist --- ja/docs/languages/erlang/sampling/index.html --> /ja/docs/concepts/sampling/#head-sampling
ja/docs/concepts/glossary/index.html
  hash does not exist --- ja/docs/concepts/glossary/index.html --> /ja/docs/what-is-opentelemetry/#history
  hash does not exist --- ja/docs/concepts/glossary/index.html --> /ja/docs/what-is-opentelemetry/#history
ja/docs/languages/js/sampling/index.html
  hash does not exist --- ja/docs/languages/js/sampling/index.html --> /ja/docs/concepts/sampling#head-sampling
ja/docs/concepts/signals/baggage/index.html
  hash does not exist --- ja/docs/concepts/signals/baggage/index.html --> /ja/docs/concepts/context-propagation/#context
  hash does not exist --- ja/docs/concepts/signals/baggage/index.html --> /ja/docs/concepts/context-propagation/#propagation
ja/docs/concepts/components/index.html
  hash does not exist --- ja/docs/concepts/components/index.html --> /ja/docs/concepts/sampling/#head-sampling
pt/docs/zero-code/php/index.html

@katzchang katzchang requested a review from a team as a code owner November 11, 2024 12:18
@opentelemetrybot opentelemetrybot requested review from a team November 11, 2024 12:18
@svrnm
Copy link
Member

svrnm commented Nov 11, 2024

thanks @katzchang!

svrnm
svrnm reviewed Nov 11, 2024
View reviewed changes
.htmltest.yml Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested review from a team November 11, 2024 16:31
@chalin chalin merged commit 416e4ed into open-telemetry:main Nov 11, 2024
17 checks passed
@chalin chalin mentioned this pull request Nov 11, 2024
Open
5 tasks
@katzchang katzchang deleted the ja-heading-ids branch November 12, 2024 01:14
drewby pushed a commit to drewby/opentelemetry.io that referenced this pull request Nov 21, 2024
@katzchang @drewby
Add missing heading ids on lang:ja (open-telemetry#5584)
3c79c00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@svrnm svrnm svrnm left review comments

Assignees
No one assigned
Labels
lang:ja
Projects
SIG Comms: Docs Translation
Status: Done
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katzchang @svrnm @chalin