Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docsy and OpAMP to 0.8.0, clean up htmltest config #3620

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Update docsy and OpAMP to 0.8.0, clean up htmltest config #3620

merged 1 commit into from
Nov 30, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 29, 2023 •
edited
Loading 

$ (cd public && git diff -bw --ignore-blank-lines -I "Hugo 0.1" -I '^\s+<a href=".*?">.*?</a></li>') | grep ^diff | head
diff --git a/docs/specs/opamp/index.html b/docs/specs/opamp/index.html
diff --git a/refcache.json b/refcache.json
diff --git a/scss/main.css.map b/scss/main.css.map
diff --git a/site/index.html b/site/index.html

The first -I ignore regex is for "generator" meta tags. The second -I ignore regex is for breadcrumbs that now use local paths rather than self-referential full URLs back into the OTel website. For details, see google/docsy#1337.

Sample diff:

$ git diff community/end-user/interviews-feedback/index.html
diff --git a/community/end-user/interviews-feedback/index.html b/community/end-user/interviews-feedback/index.html
index 0ef48c170..fecc0360d 100644
--- a/community/end-user/interviews-feedback/index.html
+++ b/community/end-user/interviews-feedback/index.html
@@ -3,7 +3,6 @@
   <head>
     <meta charset="utf-8">
 <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
-<meta name="generator" content="Hugo 0.120.4">
 <meta name="robots" content="noindex, nofollow">
 <link rel="shortcut icon" href="/favicons/favicon.ico" >
 <link rel="apple-touch-icon" href="/favicons/apple-touch-icon.png" sizes="180x180">
@@ -168,9 +167,9 @@
             <nav aria-label="breadcrumb" class="td-breadcrumbs">
   <ol class="breadcrumb">
   <li class="breadcrumb-item">
-    <a href="https://opentelemetry.io/community/">Community</a></li>
+    <a href="/community/">Community</a></li>
   <li class="breadcrumb-item">
-    <a href="https://opentelemetry.io/community/end-user/">End User</a></li>
+    <a href="/community/end-user/">End User</a></li>
   <li class="breadcrumb-item active" aria-current="page">
     Interviews or Feedback Sessions</li>
   </ol>

Preview, e.g.:

@chalin chalin requested review from a team November 29, 2023 19:24
@chalin
Copy link
Contributor Author

chalin commented Nov 29, 2023

/cc @tigrannajaryan

@chalin chalin mentioned this pull request Nov 29, 2023
Closed
6 tasks
@chalin chalin changed the title Update docsy to 0.8.0, clean up htmltest config, update OpAMP Update docsy and OpAMP to 0.8.0, clean up htmltest config Nov 29, 2023
@chalin chalin force-pushed the chalin-im-docsy-0.8.0-2023-11-29 branch from fd066b9 to f992e4a Compare November 30, 2023 10:40
@chalin chalin merged commit 4318288 into open-telemetry:main Nov 30, 2023
14 checks passed
@chalin chalin deleted the chalin-im-docsy-0.8.0-2023-11-29 branch November 30, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Docsy to 0.8.0 and check-links cleanup
2 participants
@chalin @svrnm