Fix broken semantic convention links #3395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <[email protected]>
|
Yes, that is part of a clean fix for #3392. I'd rather address all link fixes together. I'm starting work on that now. |
chalin
reviewed
Oct 17, 2023
|
Fixing all the broken links is going to be tricky (and a bit lengthy since each needs to be analyzed on a case-by-case basis), and I'm not sure that whether we'll be able to use aliases in all cases. So maybe let's move ahead with this partial fix for now as I work on the others. WDYT @svrnm? |
|
Or we can wait for my PR :) |
Co-authored-by: Patrice Chalin <[email protected]>
Since you have the best overview on all the moving pieces right now, I'll leave it to you to either merge this PR or group it into one you have |
chalin
added a commit
to chalin/opentelemetry.io
that referenced
this pull request
Oct 17, 2023
chalin
added a commit
to chalin/opentelemetry.io
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #3393, but not yet a final fix: @chalin can we have aliases for pages in the semantic convention such that the old URLs are pointing to the new pages?