Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OTel spec links to page source #2691

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented May 10, 2023

Some spec page links to GitHub page source were broken by #2677. This fixes those links and brings in a bit more code in prep for hosting the OTLP spec pages.

This PR impacts only the OTel spec pages and only the GH link URLs.

$ cd public
$ g diff | grep ^diff | grep -v 'docs/spec' # only spec pages are affected
$ g diff | grep ^diff | wc -l                                   
      96
$ g diff | grep ^diff | grep -E '^diff.*index.html$' | wc -l    # only index pages are affected
      96
$ g diff -I 'View page source|Edit this page| Create child page' # only the GH links are affected
$

Contributes to:

/cc @tigrannajaryan

@chalin chalin requested a review from a team May 10, 2023 16:08
@chalin chalin force-pushed the chalin-im-otel-spec-gh-link-fix-2023-05-10 branch from ee9f2ed to c701fc0 Compare May 10, 2023 17:09
@chalin chalin force-pushed the chalin-im-otel-spec-gh-link-fix-2023-05-10 branch from dab3a41 to 36ec816 Compare May 10, 2023 17:20
@chalin chalin merged commit 3d9fe51 into open-telemetry:main May 10, 2023
@chalin chalin deleted the chalin-im-otel-spec-gh-link-fix-2023-05-10 branch May 10, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants