-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mut
self reference from LogExporter::export() method.
#2380
base: main
Are you sure you want to change the base?
Remove mut
self reference from LogExporter::export() method.
#2380
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2380 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 123 123
Lines 21479 21484 +5
=====================================
+ Hits 17064 17068 +4
- Misses 4415 4416 +1 ☔ View full report in Codecov by Sentry. |
I think this is the right direction. Our processors are only requiring Requiring Would love to get more feedback on this, as we are close to declaring stability, so can't make breaking changes after that. |
agree, would prefer to have closer on this sooner, the slight regression seen in stress test can then be evaluated to improve with #2374. |
Changes
As discussed here - #2374 (comment)
The changes are minimal, and the stress test for the logs now includes an exporter call over the future, causing a slight regression.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes