Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Internal logs #2361

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

cijothomas
Copy link
Member

Its hard to see internal logs during initialization phase, as the fmt layer is not yet set. I set a separate one wrapping initialization code, just to see if the internal logs added in this PR are working!

let fmt_subscriber = fmt::Subscriber::builder()
    .with_env_filter(EnvFilter::new("debug"))
    .finish();
    let (logger_provider, layer) = tracing::subscriber::with_default(fmt_subscriber, || {
        let logger_provider = init_logs().unwrap();
        let layer = OpenTelemetryTracingBridge::new(&logger_provider);
        (logger_provider, layer)
    });
	
	// rest of code
2024-11-27T18:58:01.309390Z DEBUG opentelemetry_sdk:  name="LoggerProvider.Built"
2024-11-27T18:58:01.309445Z DEBUG opentelemetry_sdk:  name="LoggerProvider.NewLoggerReturned" logger_name="opentelemetry-appender-tracing"

@cijothomas cijothomas requested a review from a team as a code owner November 27, 2024 19:07
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (cbe9ebe) to head (5ead582).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/log_emitter.rs 70.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2361     +/-   ##
=======================================
- Coverage   79.5%   79.5%   -0.1%     
=======================================
  Files        123     123             
  Lines      21482   21492     +10     
=======================================
+ Hits       17087   17094      +7     
- Misses      4395    4398      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit b7276d8 into open-telemetry:main Nov 27, 2024
20 of 23 checks passed
pitoniak32 pushed a commit to pitoniak32/opentelemetry-rust that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants