-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP semantic convention stability migration for httpx #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Jun 28, 2024
instrumentation/opentelemetry-instrumentation-httpx/tests/test_httpx_integration.py
Show resolved
Hide resolved
emdneto
force-pushed
the
httpx-semconv-migration
branch
from
June 28, 2024 17:32
603bc46
to
409897f
Compare
lzchen
reviewed
Jul 1, 2024
...tion/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Jul 1, 2024
...tion/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Jul 1, 2024
...tion/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py
Show resolved
Hide resolved
lzchen
reviewed
Jul 1, 2024
...tion/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Jul 1, 2024
...tion/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Jul 1, 2024
...tion/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py
Show resolved
Hide resolved
lzchen
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of this #2453 and based on #2002
Type of change
How Has This Been Tested?
Sample below
Old semconv with envvar set to "default" or "":
New semconv with envvar set to "http" exception, error, and ok:
Both semconv with envvar set to "http/dup":
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.