Create service for extensions

[Ankit152]

Description:

The Otel Operator doesn't creates a service for extensions. This will help the operator to create Service for extensions which will be consumed by an Ingress so that users can interact with it directly. This is related to deployment of Jaeger V2 in k8s.

Link to tracking Issue(s):

• Kubernetes Operator to support Jaeger-v2  jaegertracing/jaeger-operator#2717
• [Collector] Create a service for extensions which can be exposed to a port #3460

Testing:

Documentation:

[pavolloffay]

great progress,

Please add unit tests and e2e test

[swiatekm]

This looks good to me overall, left a few comments and questions.

[swiatekm]

I wanted to be clearer about how I'd like the e2e test you added to look like. I'm including some suggestions to help demonstrate that. Fundamentally, the manifests we assert against should only contain attributes that are relevant to this specific test.

The rest of this PR looks good to me, nicely done. 👍

[jaronoff97]

nit... can you change this to be a list test instead here and also assert on the service created to be sure it has the right ports set?

[Ankit152]

Okay, I understood about asserting the ports. But can you elaborate more on list test instead? Do you mean something like this:

func TestExtensionService(t *testing.T) {
  tests := []struct{
      name.            string
      params          manifests.params
      ports              []corev1.ServicePort
      expectedErr  error
}{
      {
          ....
          ....
      },
      {
          ....
          ....
      },
}

for _,tc := range tests {
    t.Run(tc.name, func (t *testing.T){
        // assertion
    })
}

[jaronoff97]

yep! you can see an example here for these.

[Ankit152]

I have added the changes. Kindly review them!

[Ankit152]

@jaronoff97 @iblancasa @swiatekm if the changes looks good, then can we merge this one please?

[swiatekm]

LGTM, thank you for the contribution!