Create service for extensions #3403
Conversation
Ankit152
force-pushed
the
service-extension
branch
from
df4a731
to
3a5a2ee
Compare
Ankit152
force-pushed
the
service-extension
branch
from
3a5a2ee
to
3ab8c98
Compare
Ankit152
force-pushed
the
service-extension
branch
2 times, most recently
from
d742325
to
eb14bf7
Compare
Ankit152
force-pushed
the
service-extension
branch
from
eb14bf7
to
5f26d14
Compare
Ankit152
force-pushed
the
service-extension
branch
6 times, most recently
from
007c7eb
to
d9ff5df
Compare
Ankit152
force-pushed
the
service-extension
branch
2 times, most recently
from
41da859
to
5e26224
Compare
Ankit152
force-pushed
the
service-extension
branch
from
5e26224
to
4f27a6b
Compare
There was a problem hiding this comment.
I wanted to be clearer about how I'd like the e2e test you added to look like. I'm including some suggestions to help demonstrate that. Fundamentally, the manifests we assert against should only contain attributes that are relevant to this specific test.
The rest of this PR looks good to me, nicely done. 👍
Ankit152
force-pushed
the
service-extension
branch
2 times, most recently
from
c5d4b40
to
effe1d9
Compare
Ankit152
force-pushed
the
service-extension
branch
2 times, most recently
from
d25d89a
to
0091576
Compare
| @@ -321,6 +321,161 @@ func TestMonitoringService(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestExtensionService(t *testing.T) { | |||
There was a problem hiding this comment.
nit... can you change this to be a list test instead here and also assert on the service created to be sure it has the right ports set?
There was a problem hiding this comment.
Okay, I understood about asserting the ports. But can you elaborate more on list test instead? Do you mean something like this:
func TestExtensionService(t *testing.T) {
tests := []struct{
name. string
params manifests.params
ports []corev1.ServicePort
expectedErr error
}{
{
....
....
},
{
....
....
},
}
for _,tc := range tests {
t.Run(tc.name, func (t *testing.T){
// assertion
})
}
There was a problem hiding this comment.
yep! you can see an example here for these.
There was a problem hiding this comment.
I have added the changes. Kindly review them!
There was a problem hiding this comment.
@jaronoff97 @iblancasa @swiatekm if the changes looks good, then can we merge this one please?
Ankit152
force-pushed
the
service-extension
branch
from
0091576
to
b90db6c
Compare
Ankit152
force-pushed
the
service-extension
branch
2 times, most recently
from
be77545
to
6751006
Compare
Signed-off-by: Ankit152 <[email protected]>
Signed-off-by: Ankit152 <[email protected]>
Signed-off-by: Ankit152 <[email protected]>
Signed-off-by: Ankit152 <[email protected]>
Ankit152
force-pushed
the
service-extension
branch
from
6751006
to
c3ebb64
Compare
Description:
The Otel Operator doesn't creates a service for extensions. This will help the operator to create Service for extensions which will be consumed by an Ingress so that users can interact with it directly. This is related to deployment of Jaeger V2 in k8s.
Link to tracking Issue(s):
Testing:
Documentation: