Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: add golvulncheck in linting job #4598

Merged
merged 9 commits into from
Oct 10, 2023

Conversation

sakshi-1505
Copy link
Contributor

@sakshi-1505 sakshi-1505 commented Oct 9, 2023

Towards #4459

@sakshi-1505
Copy link
Contributor Author

@pellared please check

@pellared
Copy link
Member

pellared commented Oct 9, 2023

How have you been testing it?

@sakshi-1505
Copy link
Contributor Author

How have you been testing it?

I did make lint on my local

sakshi-1505 and others added 3 commits October 9, 2023 14:42
Signed-off-by: sakshi-1505 <[email protected]>
Signed-off-by: sakshi-1505 <[email protected]>
@sakshi-1505
Copy link
Contributor Author

@pellared I had forgotten to push a commit which actually added govulncheck in the go modules.

Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 9, 2023
@pellared
Copy link
Member

pellared commented Oct 9, 2023

From https://github.com/open-telemetry/opentelemetry-go/actions/runs/6454634525/job/17521765038?pr=4598

Working tree is not clean, did you forget to run "make precommit"?

Signed-off-by: sakshi-1505 <[email protected]>
@sakshi-1505
Copy link
Contributor Author

@pellared I have made the changes as you suggested & ran the precommit too now

Makefile Outdated Show resolved Hide resolved
@pellared

This comment was marked as resolved.

@pellared
Copy link
Member

pellared commented Oct 9, 2023

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #4598 (689c6b4) into main (68241af) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4598   +/-   ##
=====================================
  Coverage   81.3%   81.3%           
=====================================
  Files        221     221           
  Lines      17686   17686           
=====================================
+ Hits       14391   14393    +2     
+ Misses      2995    2993    -2     
  Partials     300     300           

see 1 file with indirect coverage changes

@pellared pellared merged commit f3b9849 into open-telemetry:main Oct 10, 2023
23 checks passed
@pellared
Copy link
Member

@sakshi-1505 Thank you for your contribution 🎉

Can you create a similar PR for https://github.com/open-telemetry/opentelemetry-go-contrib and https://github.com/open-telemetry/opentelemetry-go-build-tools?

@sakshi-1505
Copy link
Contributor Author

sakshi-1505 commented Oct 10, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants