-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: add golvulncheck in linting job #4598
Conversation
Signed-off-by: sakshi-1505 <[email protected]>
@pellared please check |
How have you been testing it? |
I did |
Signed-off-by: sakshi-1505 <[email protected]>
Signed-off-by: sakshi-1505 <[email protected]>
@pellared I had forgotten to push a commit which actually added govulncheck in the go modules. |
From https://github.com/open-telemetry/opentelemetry-go/actions/runs/6454634525/job/17521765038?pr=4598
|
Signed-off-by: sakshi-1505 <[email protected]>
03c6009
to
1487cc9
Compare
@pellared I have made the changes as you suggested & ran the precommit too now |
This comment was marked as resolved.
This comment was marked as resolved.
@sakshi-1505, can you create a similar PR for https://github.com/open-telemetry/opentelemetry-go-contrib? You can also do it for https://github.com/open-telemetry/opentelemetry-go-build-tools to solve open-telemetry/opentelemetry-go-build-tools#390 |
Codecov Report
@@ Coverage Diff @@
## main #4598 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 221 221
Lines 17686 17686
=====================================
+ Hits 14391 14393 +2
+ Misses 2995 2993 -2
Partials 300 300 |
@sakshi-1505 Thank you for your contribution 🎉 Can you create a similar PR for https://github.com/open-telemetry/opentelemetry-go-contrib and https://github.com/open-telemetry/opentelemetry-go-build-tools? |
Sure thing!
…On Tue, 10 Oct 2023 at 14:14, Robert Pająk ***@***.***> wrote:
@sakshi-1505 <https://github.com/sakshi-1505> Thank you for your
contribution 🎉
Can you create a similar PR for
https://github.com/open-telemetry/opentelemetry-go-contrib and
https://github.com/open-telemetry/opentelemetry-go-build-tools?
—
Reply to this email directly, view it on GitHub
<#4598 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDCZVU3SUNR4S6B3DYNSJJLX6UDHPAVCNFSM6AAAAAA5YOZK5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJUG4YTMNZWGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Towards #4459