Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(otelgin): move test files and trim module dependencies #6360

Merged
merged 6 commits into from
Nov 25, 2024
Merged

tests(otelgin): move test files and trim module dependencies #6360

merged 6 commits into from
Nov 25, 2024

Conversation

flc1125
Copy link
Contributor

@flc1125 flc1125 commented Nov 22, 2024

No description provided.

@flc1125 flc1125 requested a review from a team as a code owner November 22, 2024 04:46
dmathieu
dmathieu reviewed Nov 22, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Nov 22, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.9%. Comparing base (b508e33) to head (05a19e9).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6360   +/-   ##
=====================================
  Coverage   66.9%   66.9%           
=====================================
  Files        193     193           
  Lines      15652   15652           
=====================================
  Hits       10480   10480           
  Misses      4881    4881           
  Partials     291     291
---- 🚨 Try these New Features:

dmathieu
dmathieu approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not having b3 as a dependency of the instrumentation anymore is nice.

@pellared pellared changed the title tests(otelgin): move test files and simplify main package dependencies tests(otelgin): move test files and trim module dependencies Nov 22, 2024
@pellared pellared merged commit 41cc753 into open-telemetry:main Nov 25, 2024
26 checks passed
@flc1125 flc1125 deleted the move-tests branch November 25, 2024 15:25
@flc1125 flc1125 mentioned this pull request Nov 27, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@pellared pellared pellared approved these changes

Assignees
No one assigned
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flc1125 @dmathieu @pellared