Skip SDK upgrades that are pinned to a specific commit #6238

Victorsesan · 2024-10-13T01:29:58Z

No description provided.

…sable updates when the dependency is pinned to a specific commit or digest. The final rule ensures no updates are applied if the dependency's version source URL is a commit SHA. Related to open-telemetry#6192

…o-contrib

dmathieu · 2024-10-13T15:38:42Z

This also changes some unrelated formatting of the file, making the diff harder to read. Could you remove those unrelated formats ?

Victorsesan · 2024-10-13T20:38:25Z

@dmathieu I've maintained the fille structure and ensured formatting is consistent and easy to read I'm not sure if that fixed it. Also the renovate bot link; renovate-schema.js file is unable to load from my end not sure why but maybe it could be the problem. Please let me know if that changed anything, thanks

…nd easy to read Relate to open-telemetry#6238

renovate.json

Relate to open-telemetry#6238

renovate.json

…mplified content for reference/comments for the config package Related to open-telemetry#6238

renovate.json

Co-authored-by: Damien Mathieu <[email protected]>

dmathieu

Left two nits.

dmathieu · 2024-10-17T08:12:30Z

renovate.json

+      }
+    },
+    {
+        "_description": "Any SDK upgrade that made it through here is a pin/digest. DIsable it",


Suggested change

"_description": "Any SDK upgrade that made it through here is a pin/digest. DIsable it",

"_description": "Any SDK upgrade that made it through here is a pin/digest. Disable it",

dmathieu · 2024-10-17T08:13:00Z

renovate.json

@@ -31,8 +27,18 @@
      "groupName": "golang.org/x"
    },
    {
+        "_description": "Ignore pin and digest upgrades. We only want published releases of the SDK to trigger upgrades",   


Suggested change

"_description": "Ignore pin and digest upgrades. We only want published releases of the SDK to trigger upgrades",

"_description": "Ignore pin and digest upgrades. We only want published releases of the SDK to trigger upgrades",

codecov · 2024-10-17T08:15:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.2%. Comparing base (856523b) to head (890e925).
Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #6238     +/-   ##
=======================================
+ Coverage   66.9%   67.2%   +0.2%     
=======================================
  Files        190     191      +1     
  Lines      12540   12637     +97     
=======================================
+ Hits        8395    8494     +99     
+ Misses      3855    3854      -1     
+ Partials     290     289      -1

see 6 files with indirect coverage changes

pellared · 2024-10-18T09:28:06Z

renovate.json

-      "allowedVersions": "/^v[0-9]+\\.[0-9]+\\.[0-9]+/"
+      "enabled": true,
+      "ignore": {
+        "matchUpdateTypes": ["pin", "digest"]


What is a pin?

It looks like it's a dependency set at an explicit version.
https://docs.renovatebot.com/dependency-pinning/

Pinning isn't something we can really do with Go. But just to be same, maybe we should actually remove that match.

I would prefer this PR to be tested on a fork.
@Victorsesan, can you test it on https://github.com/Victorsesan/opentelemetry-go-contrib?

@pellared I would be happy to! sorry for messing it up , i'm trying but my PR keeps getting tested here instead can you please give me some pointers on how to test directly on my fork repo . thanks

@dmathieu Did we succeeded in fixing this issue i would love a feedback if there is anything else i need to do i will be happy to! Thanks

@pellared @dmathieu Are these the expected test we need to see? Thanks for the time

They would be, yes. But in your screenshot, they appear to say the configuration file is invalid.

@dmathieu Finally succeeded in making renovate work as expected after a long try and errors, i had to make some minor changes for it to pass the test which I'm not sure if its good or bad but i mentioned all the errors i faced with the solution and modifications i did in my recent commit which i will be happy if you can check it out and let me know if we are in the right track. I would love to succeed in working on this . Thank you all for your time.

This shows the config is valid. But it doesn't seem to validate that commit upgrades would be skipped, while releases would be bumped?

hows the config is valid. But it doesn't seem to validate that commit upgrades would be skipped, while releases would be bumped

@dmathieu Sorry i missed that, is this last commit good i have added something to fix it. I was just worried with mend not accepting the package rules even when they are good sometimes which made me lost track validating the skip rule and rather focus on having renovate pass the test, but let me know if the few changes i made does it and it did also pass the test. thanks

…o-contrib

Problems i found with mend.io -After runnig the first test, the errors indicated that certain options are invalid, specifically the _description and ignore fields in my packageRules which i had to change and remove. *Solution: I removed _description Fields as they were classified as not a valid options in the Renovate configuration. *Kept the ignore Field which was valid, but ensured that it is used correctly. In this case, it remains in the rule for go.opentelemetry.io/otel/** -I ran a second test which had another error. The ignore field in packageRules[4] was still causing issues. The ignore option was not valid in the context of packageRules. *Solution: I used instead an enabled field to control whether updates are applied.

…o-contrib

…mit upgrades. This will ensure that any dependency that is not explicitly allowed will be skipped.

Victorsesan added 2 commits October 11, 2024 00:58

I have dded an ignore property under the matchPackageNames rule to di…

6669a57

…sable updates when the dependency is pinned to a specific commit or digest. The final rule ensures no updates are applied if the dependency's version source URL is a commit SHA. Related to open-telemetry#6192

Merge branch 'main' of https://github.com/Victorsesan/opentelemetry-g…

ca9329b

…o-contrib

Victorsesan requested a review from a team as a code owner October 13, 2024 01:29

Merge branch 'main' into main

c7e17f7

Maintained the fille structure and ensured formatting is consistent a…

41ba61d

…nd easy to read Relate to open-telemetry#6238

dmathieu reviewed Oct 14, 2024

View reviewed changes

renovate.json Outdated Show resolved Hide resolved

renovate.json Show resolved Hide resolved

Added a comment with explanation from line 37-48

ee1f88c

Relate to open-telemetry#6238

dmathieu reviewed Oct 15, 2024

View reviewed changes

renovate.json Outdated Show resolved Hide resolved

renovate.json Outdated Show resolved Hide resolved

Victorsesan and others added 2 commits October 16, 2024 00:53

Removed allowed version regex, added ymalconfig which includes YAML a…

bf006b8

…mplified content for reference/comments for the config package Related to open-telemetry#6238

Merge branch 'main' into main

6ef0aeb

dmathieu reviewed Oct 16, 2024

View reviewed changes

renovate.json Outdated Show resolved Hide resolved

renovate.json Show resolved Hide resolved

renovate.json Show resolved Hide resolved

dmathieu changed the title ~~Aded an ignore property under the matchPackageNames rule to disable updates when the dependency is pinned to a specific commit or digest~~ Skip SDK upgrades that are pinned to a specific commit Oct 16, 2024

Victorsesan and others added 3 commits October 17, 2024 01:55

Update renovate.json

5759272

Co-authored-by: Damien Mathieu <[email protected]>

Update renovate.json

5142d38

Co-authored-by: Damien Mathieu <[email protected]>

Update renovate.json

890e925

Co-authored-by: Damien Mathieu <[email protected]>

dmathieu approved these changes Oct 17, 2024

View reviewed changes

dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Oct 17, 2024

pellared reviewed Oct 18, 2024

View reviewed changes

Victorsesan and others added 9 commits October 19, 2024 01:40

#

75f4c3a

Merge branch 'main' of https://github.com/Victorsesan/opentelemetry-g…

b71ad98

…o-contrib

Merge branch 'open-telemetry:main' into main

21bc6b7

#

2161304

Merge branch 'main' of https://github.com/Victorsesan/opentelemetry-g…

6599828

…o-contrib

Merge branch 'open-telemetry:main' into main

7827145

Merge branch 'main' of https://github.com/Victorsesan/opentelemetry-g…

6c3c11b

…o-contrib

A last rule ("matchPackageNames": ["*"]) was added to disable all com…

f2ca314

…mit upgrades. This will ensure that any dependency that is not explicitly allowed will be skipped.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip SDK upgrades that are pinned to a specific commit #6238

Skip SDK upgrades that are pinned to a specific commit #6238

Victorsesan commented Oct 13, 2024

dmathieu commented Oct 13, 2024

Victorsesan commented Oct 13, 2024

dmathieu left a comment

dmathieu Oct 17, 2024

dmathieu Oct 17, 2024

codecov bot commented Oct 17, 2024 •

edited

Loading

pellared Oct 18, 2024

dmathieu Oct 18, 2024

pellared Oct 18, 2024 •

edited

Loading

Victorsesan Oct 19, 2024

Victorsesan Oct 20, 2024

Victorsesan Oct 23, 2024

dmathieu Oct 24, 2024

Victorsesan Oct 25, 2024

dmathieu Oct 25, 2024

Victorsesan Oct 25, 2024

	"_description": "Any SDK upgrade that made it through here is a pin/digest. DIsable it",
	"_description": "Any SDK upgrade that made it through here is a pin/digest. Disable it",

	"_description": "Ignore pin and digest upgrades. We only want published releases of the SDK to trigger upgrades",
	"_description": "Ignore pin and digest upgrades. We only want published releases of the SDK to trigger upgrades",

Skip SDK upgrades that are pinned to a specific commit #6238

Are you sure you want to change the base?

Skip SDK upgrades that are pinned to a specific commit #6238

Conversation

Victorsesan commented Oct 13, 2024

dmathieu commented Oct 13, 2024

Victorsesan commented Oct 13, 2024

dmathieu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 17, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pellared Oct 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 17, 2024 •

edited

Loading

pellared Oct 18, 2024 •

edited

Loading