Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] diagram defining different states for issues #36975

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VihasMakwana
Copy link
Contributor

Description

See #36677

Closes #36677

n2 -- Yes --> n3
n2 -- No/Need more details --> n4
n2 -- Invalid configuration/alternative available --> n5(["Provide a detailed comment on the issue and close it."])
n3 --> n6["Codeowner has time<br>to fix it?"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add an arrow for codeowners to reject the issue, in case that's not clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks for this. I'll add that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atoulme once you're back, pleas take a look!

@VihasMakwana VihasMakwana requested a review from atoulme December 31, 2024 13:42
n6 -- No --> n8
n7 --> n9(["Issue closed once fix is merged"])
n8 --> n9
n4 -- Once enough detailsare available --> n2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
n4 -- Once enough detailsare available --> n2
n4 -- Once enough details are available --> n2

n3 -- Valid Issue --> n6["Codeowner has time<br>to fix it?"]
n6 -- Yes --> n7["Valid issue and to be fixed <br>by a codeowner"]
n6 -- No --> n8
n7 --> n9(["Issue closed once fix is merged"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we add an independent subgraph close issue and several subgraphs denotes the actions before closing issue to point to subgraph close issue, since the issues could be closed by several different actions, e.g., creating a pr, mark as invalid or duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define states an issue can be at
4 participants